fix: invalid error handling (#2610)

Signed-off-by: Jim Ma <[email protected]>
dragonflyoss · Aug 8, 2023 · 9cc9fa2 · 9cc9fa2
1 parent bd140f1
commit 9cc9fa2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/manager/service/preheat.go b/manager/service/preheat.go
@@ -67,6 +67,7 @@ func (s *service) GetV1Preheat(ctx context.Context, rawID string) (*types.GetV1P
 	id, err := strconv.ParseUint(rawID, 10, 32)
 	if err != nil {
 		logger.Errorf("preheat convert error", err)
+		return nil, status.Error(codes.Unknown, err.Error())
 	}
 
 	job := models.Job{}

diff --git a/pkg/source/transport_option.go b/pkg/source/transport_option.go
@@ -53,6 +53,7 @@ func UpdateTransportOption(transport *http.Transport, optionYaml []byte) error {
 		proxy, err := url.Parse(opt.Proxy)
 		if err != nil {
 			fmt.Printf("proxy parse error: %s\n", err)
+			return err
 		}
 		transport.Proxy = http.ProxyURL(proxy)
 	}