fix: mismatch digest peer task did not mark invalid (#903)

Signed-off-by: Jim Ma <[email protected]>
dragonflyoss · Dec 9, 2021 · 82aebc6 · 82aebc6
1 parent 4343f62
commit 82aebc6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/client/daemon/storage/local_storage.go b/client/daemon/storage/local_storage.go
@@ -175,6 +175,7 @@ func (t *localTaskStore) ValidateDigest(*PeerTaskMetadata) error {
 	t.Lock()
 	defer t.Unlock()
 	if t.persistentMetadata.PieceMd5Sign == "" {
+		t.invalid.Store(true)
 		return ErrDigestNotSet
 	}
 	if t.TotalPieces <= 0 {
@@ -184,13 +185,14 @@ func (t *localTaskStore) ValidateDigest(*PeerTaskMetadata) error {
 	}
 
 	var pieceDigests []string
-	for i := int32(0); i < int32(t.TotalPieces); i++ {
+	for i := int32(0); i < t.TotalPieces; i++ {
 		pieceDigests = append(pieceDigests, t.Pieces[i].Md5)
 	}
 
 	digest := digestutils.Sha256(pieceDigests...)
 	if digest != t.PieceMd5Sign {
 		t.Errorf("invalid digest, desired: %s, actual: %s", t.PieceMd5Sign, digest)
+		t.invalid.Store(true)
 		return ErrInvalidDigest
 	}
 	return nil