add header check for ClientOption (#1174)

Signed-off-by: yxxhero <[email protected]>

client/config/deprecated.go

@@ -36,9 +36,7 @@ type SupernodesValue struct {
 // String implements the pflag.Value interface.
 func (sv *SupernodesValue) String() string {
 	var result []string
-	for _, v := range sv.Nodes {
-		result = append(result, v)
-	}
+	result = append(result, sv.Nodes...)
 	return strings.Join(result, ",")
 }
 

client/config/dfget.go

@@ -159,6 +159,10 @@ func (cfg *ClientOption) Validate() error {
 		return errors.Wrapf(dferrors.ErrInvalidArgument, "output: %v", err)
 	}
 
+	if err := cfg.checkHeader(); err != nil {
+		return errors.Wrapf(dferrors.ErrInvalidHeader, "output: %v", err)
+	}
+
 	return nil
 }
 
@@ -198,6 +202,25 @@ func (cfg *ClientOption) String() string {
 	return string(js)
 }
 
+// checkHeader is for checking the header format
+func (cfg *ClientOption) checkHeader() error {
+	if len(cfg.Header) == 0 {
+		return nil
+	}
+
+	for _, header := range cfg.Header {
+		if !strings.Contains(header, ":") {
+			return fmt.Errorf("header format error: %v", header)
+		}
+		idx := strings.Index(header, ":")
+		if len(strings.TrimSpace(header[:idx])) == 0 || len(strings.TrimSpace(header[idx+1:])) == 0 {
+			return fmt.Errorf("header format error: %v", header)
+		}
+	}
+
+	return nil
+}
+
 // This function must be called after checkURL
 func (cfg *ClientOption) checkOutput() error {
 	if !filepath.IsAbs(cfg.Output) {

client/config/dfget_test.go

@@ -138,3 +138,28 @@ func TestMkdirAll(t *testing.T) {
 		})
 	}
 }
+
+func TestCheckHeader(t *testing.T) {
+	cfg := NewDfgetConfig()
+
+	// test empty header
+	testifyassert.Nil(t, cfg.checkHeader())
+
+	// test normal headers
+	cfg.Header = []string{
+		"a:b",
+		"1:1",
+		"1:a",
+		"a:1",
+	}
+	testifyassert.Nil(t, cfg.checkHeader())
+
+	// test error headers
+	cfg.Header = []string{
+		":",
+		"a",
+		" :a",
+		"a: ",
+	}
+	testifyassert.NotNil(t, cfg.checkHeader())
+}

internal/dferrors/error.go

@@ -27,6 +27,7 @@ import (
 // common and framework errors
 var (
 	ErrInvalidArgument = errors.New("invalid argument")
+	ErrInvalidHeader   = errors.New("invalid Header")
 	ErrDataNotFound    = errors.New("data not found")
 	ErrEmptyValue      = errors.New("empty value")
 	ErrConvertFailed   = errors.New("convert failed")