Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: scheduler evaluator #805

Merged
merged 6 commits into from
Nov 18, 2021
Merged

refactor: scheduler evaluator #805

merged 6 commits into from
Nov 18, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 16, 2021

Description

  •  Refactor scheduler evaluator.

Related Issue

Fixes #802

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 16, 2021
@gaius-qi gaius-qi self-assigned this Nov 16, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 16, 2021 13:37
@gaius-qi gaius-qi force-pushed the feature/evaluator branch 4 times, most recently from 0b6077b to 6a7afbf Compare November 17, 2021 02:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #805 (613c919) into main (9278caa) will increase coverage by 0.39%.
The diff coverage is 83.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   40.68%   41.07%   +0.39%     
==========================================
  Files          95       98       +3     
  Lines        7812     7896      +84     
==========================================
+ Hits         3178     3243      +65     
- Misses       4229     4246      +17     
- Partials      405      407       +2     
Flag Coverage Δ
unittests 41.07% <83.17%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/idgen/task_id.go 100.00% <ø> (ø)
pkg/util/mathutils/math_utils.go 20.00% <0.00%> (-7.78%) ⬇️
scheduler/config/config.go 4.81% <0.00%> (+0.11%) ⬆️
scheduler/supervisor/host.go 60.00% <ø> (+3.75%) ⬆️
scheduler/core/evaluator/plugin.go 50.00% <50.00%> (ø)
scheduler/core/evaluator/evaluator.go 71.42% <71.42%> (ø)
scheduler/core/evaluator/evaluator_base.go 93.90% <93.90%> (ø)
scheduler/supervisor/peer.go 48.27% <100.00%> (-2.48%) ⬇️
client/daemon/peer/peertask_stream.go 53.82% <0.00%> (-2.15%) ⬇️
... and 1 more

@gaius-qi gaius-qi force-pushed the feature/evaluator branch 10 times, most recently from f75902d to 15d314d Compare November 18, 2021 08:06
cutecutecat
cutecutecat previously approved these changes Nov 18, 2021
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 08b8c2b into main Nov 18, 2021
@gaius-qi gaius-qi deleted the feature/evaluator branch November 18, 2021 11:48
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* refactor: scheduler evaluator

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
…dragonflyoss#805)

Revert "Refactor(deps)  update rust and golang versions in dockerfile (dragonflyoss#804)"

This reverts commit a70ecd8.

Signed-off-by: yxxhero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor scheduler evaluator
5 participants