chore: Fix all clang build warnings #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `-Werror` to clang build in CI. Fixes #4449
chakaz
changed the title
|
@chakaz what are the changes in helio? |
Without which we can't enable |
kostasrim
reviewed
Jan 20, 2025
| @@ -1807,7 +1807,7 @@ void DestroyGroup(facade::CmdArgParser* parser, Transaction* tx, SinkReplyBuilde | |||
| if (parser->HasNext()) | |||
| return builder->SendError(UnknownSubCmd("DESTROY", "XGROUP")); | |||
|
|
|||
| auto cb = [&](Transaction* t, EngineShard* shard) { | |||
| auto cb = [&, &key = key, &gname = gname](Transaction* t, EngineShard* shard) { | |||
There was a problem hiding this comment.
pfff captured structure bindings requiring c++20 extension to compile without warning pre C++20 😱
|
@adiholden we have an OK from @romange 🥳 |
kostasrim
approved these changes
Jan 20, 2025
she is away, I accepted it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
-Werrorto clang build in CI.Fixes #4449