fix: hiredis requires df to report version >7.4 #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Jan 17, 2025
| @@ -26,3 +26,4 @@ pytest-icdiff==0.8 | |||
| pytest-timeout==2.2.0 | |||
| asyncio==3.4.3 | |||
| fakeredis[json]==2.26.2 | |||
| hiredis==2.4.0 | |||
There was a problem hiding this comment.
Throwing this here, hiredis 3.0 is incompatible with redis 5.2 (latest release).
TODO bump up the versions once they are fixed
There was a problem hiding this comment.
More on this redis/hiredis-py#189 and redis/redis-py#3358 (comment)
Signed-off-by: kostas <[email protected]>
Signed-off-by: kostas <[email protected]>
romange
reviewed
Jan 20, 2025
| @@ -230,7 +230,7 @@ using strings::HumanReadableNumBytes; | |||
|
|
|||
| namespace { | |||
|
|
|||
| const auto kRedisVersion = "7.2.0"; | |||
| const auto kRedisVersion = "7.4.0"; | |||
There was a problem hiding this comment.
consider exposing it in common.h as a constant (or other header file) and then reference it in tests reduce amount of manual changes
There was a problem hiding this comment.
It's only used in dragonfly_test.cc so not much we gain here. There rest are python changes because the newer versions of the lib deprecated some of the old functions.
I am merging this and will follow up on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hiredis checks for redis version and requires to be greater than 7.4. Dragonfly reports 7.2 and the library throws an error.
Resolves #4473