fix(nvmf): set executable bit on nvmf-autoconnect.sh
#1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's installed in /sbin, and run via initqueue in the special case of FC transport without a discovery.conf and without kernel arguments. If the executable bit is not set, initqueue fails with "Invalid command". Caught by CI checking for non-executable files in binary directories.
github-actions
bot
added
modules
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
May 25, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
May 26, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
May 31, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
May 31, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nvmf-autoconnect.shis installed in/sbin, and run viainitqueuein the special case of FC transport without adiscovery.confand without kernel arguments. If the executable bit is not set,initqueuefails withInvalid command.Caught by CI checking for non-executable files in binary directories: coreos/fedora-coreos-tracker#1155
Checklist