weather.sh: added timeouts & checking for 'wttr.in' #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still using BASH's builtin TCP connections for testing. Added the timeout command so that the status bar doesn't have "NOT READY". Also addded a check for 'wttr.in' port 443 as that site is used to get the actual weather information.
|
Oh yeah good point. I had not considered that. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on to my previous request that changed how status was checked for the weather sites. This edit is still using BASH's builtin TCP connections for testing. Added the timeout command so that the status bar doesn't have "NOT READY". Also added a check for 'wttr.in' port 443 as that site is used to get the actual weather information.
I also changed the displayed message when either site is unavailable from "Location Unavailable" to "Weather Unavailable" as it could be either 'wttr.in' or 'ipinfo.io' that is down and causing the error.