REGRESSION(288829@main) [CMake] Build failure with clang-18 crashing …

…on Vector::map and complex LengthPercentage templates https://bugs.webkit.org/show_bug.cgi?id=286004

Reviewed by NOBODY (OOPS!).

Related to llvm's llvm/llvm-project#93206, a fix
that's part of clang-19. As clang-18 is still quite new and the version
in distros like Ubuntu 24.04 LTS, we are adding a workaround on this
commit.

Thanks to Fujii Hironori for the suggested simpler fix of removing the
lambda return type instead of replacing the map with a for loop.

* Source/WebCore/rendering/shapes/LayoutShape.cpp:
(WebCore::LayoutShape::createShape):
* Source/WebCore/style/values/shapes/StylePolygonFunction.cpp:
(WebCore::Style::PathComputation<Polygon>::operator):

Source/WebCore/rendering/shapes/LayoutShape.cpp

@@ -151,7 +151,7 @@ Ref<const LayoutShape> LayoutShape::createShape(const Style::BasicShape& basicSh
         [&](const Style::PolygonFunction& polygon) -> Ref<LayoutShape> {
             auto boxSize = FloatSize { boxWidth, boxHeight };
 
-            auto vertices = polygon->vertices.value.map([&](const auto& vertex) -> FloatPoint {
+            auto vertices = polygon->vertices.value.map([&](const auto& vertex) {
                 return physicalPointToLogical(Style::evaluate(vertex, boxSize) + borderBoxOffset, logicalBoxSize.height(), writingMode);
             });
 

Source/WebCore/style/values/shapes/StylePolygonFunction.cpp

@@ -62,7 +62,7 @@ WebCore::Path PathComputation<Polygon>::operator()(const Polygon& value, const F
 {
     auto boundingLocation = boundingBox.location();
     auto boundingSize = boundingBox.size();
-    auto points = value.vertices.value.map([&](const auto& vertex) -> FloatPoint {
+    auto points = value.vertices.value.map([&](const auto& vertex) {
         return evaluate(vertex, boundingSize) + boundingLocation;
     });
     return cachedPolygonPath(points);