fix: Do not render hidden form fields twice #1848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With all existing form widgets hidden fields are rendered twice, once via
{{form.hidden_tag()}}
and once via{{ lib.render_field(...) }}
This PR excludes the rendering from
lib.render_field()
.Additionally, it gets rid of a closing
</td>
for every hidden field for which there was no opening tag.There is still a empty
<tr></tr>
remaining, because the code structure.Example
Before
After
ADDITIONAL INFORMATION