Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Turn on debug view for debug builds #910

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

MaximBelov
Copy link

@MaximBelov MaximBelov commented Nov 19, 2024

https://firebase.google.com/docs/analytics/debugview

https://github.com/firebase/firebase-ios-sdk/blob/e8c71d1f7f3363b488f9f2045845afbb82fd016a/FirebaseCore/Sources/FIRLogger.m#L75

firebase/firebase-ios-sdk#13640 (comment)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

@MaximBelov MaximBelov changed the title ios: Turn on debug view for debug builds feat(ios): Turn on debug view for debug builds Nov 19, 2024
@MaximBelov MaximBelov marked this pull request as ready for review November 20, 2024 05:30
@dpa99c dpa99c changed the base branch from master to dev November 22, 2024 07:51
@dpa99c dpa99c merged commit 2f9858f into dpa99c:dev Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants