POC: Use gRPC instead of HTTP to communicate to services #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanyiFeng
reviewed
Jan 13, 2020
| if (config.type === 'grpc') { | ||
| return new GrpcGraphQLDataSource(config); | ||
| } | ||
| return new RemoteGraphQLDataSource(config); |
There was a problem hiding this comment.
are we trying to handle both grpc and http case now?
There was a problem hiding this comment.
I left it in there during my experimentation. I don't see any harm in allowing both in case some service really wants to expose an HTTP /graphql endpoint, but we will encourage the use gRPC
| require 'json' | ||
| require_relative './gen/federation_api_pb' | ||
| require_relative './gen/federation_api_services_pb' | ||
|
|
There was a problem hiding this comment.
Let's call this file graphql_grpc_server
There was a problem hiding this comment.
This is just a proof of concept 😉
|
This approach LGTM, can you run it with the frontend infra team? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement and use our own
GrpcGraphQLDataSourceinstead of relying on apollo-gateway's default HTTP data source.Manual Testing
To test it out, follow the instructions here: https://github.com/Gusto/apollo-federation-ruby#example
Open up the graphql playground after starting the gateway by visiting
http://localhost:50000/graphqlFuture
Apollo has plans in the future to make their server less reliant on HTTP, which will make this even easier (since right now we have to pull out and ignore the
httpfield of the request).