Can't remove on Many-To-Many relations

[izundo-viennv]

Hi @doug-martin,
I trying to add a many relation to my user resolver, I can call add many, but I can't call with remove many and it reports an error like this:

[izundo-viennv]

@doug-martin I debugged and found that position of parameters (relationName and id) are wrong in the file relation-query.service.ts

  async removeRelations<Relation>(
    id: string | number,
    relationName: string,
    relationIds: (string | number)[],
  ): Promise<DTO> {
    const entity = await this.repo.findOneOrFail(id);
    await this.createRelationQueryBuilder(entity, relationName).remove(relationIds);
    return this.assembler.convertToDTO(entity);
  }

It should be

async removeRelations<Relation>(
    relationName: string,
    id: string | number,
    relationIds: (string | number)[],
  ): Promise<DTO> {
    const entity = await this.repo.findOneOrFail(id);
    await this.createRelationQueryBuilder(entity, relationName).remove(relationIds);
    return this.assembler.convertToDTO(entity);
  }

[izundo-viennv]

I'm glad if you give me permissions to create PR for this issue

[doug-martin]

Fixed and published @nestjs-query/[email protected]

Thanks for the bug report!