Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Remove duplicate references #6704

Merged
merged 8 commits into from
Jun 21, 2022
Merged

[release/6.0] Remove duplicate references #6704

merged 8 commits into from
Jun 21, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 20, 2022 •
edited
Loading

Backport of #6648 & #6698, should fix build errors in 6.0

Microsoft Reviewers: Open in CodeFlow

@wtgodbe wtgodbe requested a review from vseanreesermsft June 20, 2022 17:30
@wtgodbe wtgodbe requested a review from a team as a code owner June 20, 2022 17:30
@ghost ghost assigned wtgodbe Jun 20, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 20, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent June 20, 2022 17:30
@dipeshmsft
Copy link
Member

@wtgodbe there was one more part to this PR, #6698. We would have to port that too, for the builds to work.

@wtgodbe wtgodbe changed the title [release/6.0] Remove duplicate reference [release/6.0] Remove duplicate references Jun 20, 2022
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 20, 2022

@wtgodbe there was one more part to this PR, #6698. We would have to port that too, for the builds to work.

Just updated this PR

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 20, 2022

@dipeshmsft I'm still seeing errors (I see the same error in the internal build for main):

C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(3257,5): error MSB3577: (NETCORE_ENGINEERING_TELEMETRY=Build) Two output file names resolved to the same output path: "D:\a_work\1\s\artifacts\obj\System.Printing\ARM64\Debug\net6.0\System.Printing.resources"

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 21, 2022

This fixed public builds, but internal will still be broken because we don't have a queue we can use there - discussing a solution offline (don't merge this yet)

@wtgodbe wtgodbe added the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 21, 2022
@wtgodbe wtgodbe merged commit 748b0b3 into release/6.0 Jun 21, 2022
@wtgodbe wtgodbe deleted the wtgodbe-patch-1 branch June 21, 2022 17:50
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vseanreesermsft vseanreesermsft vseanreesermsft approved these changes

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@wtgodbe wtgodbe

Labels
* NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @dipeshmsft @vseanreesermsft @singhashish-wpf