Move away from BinaryFormatter for ActiveX purposes #9104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PropertyBags now serialize without it where possible. This allows a standard Control to completely serialize without the BinaryFormatter enabled. For the AxHost case, I've left the BinaryFormatter as a fall-back. I've also extended the Hashtable serialization to handle all primitive types. Note the two line change to make this happen. :) This change also moves the "Reader" methods to "BinaryFormattedObjectExtensions". Due to our layering and the need to check multiple states I realized that we need to have all of the reading of objects directly using an existing BinaryFormattedObject instance. Fixes a few bugs and adds more tests. Some random cleanup related to VARIANT (as I was exploring the scope of things).
ghost
assigned
JeremyKuhne
commented
May 11, 2023
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/BinaryFormat/BinaryFormatWriter.cs
Show resolved
Hide resolved
JeremyKuhne
commented
May 11, 2023
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/BinaryFormat/BinaryFormatReader.cs
Show resolved
Hide resolved
KlausLoeffelmann
approved these changes
May 11, 2023
| @@ -938,7 +938,7 @@ private static Span<T> GetSpan<T>(Array array) | |||
| private static T ThrowInvalidCast<T>() => throw new InvalidCastException(); | |||
|
|
|||
| /// <summary> | |||
| /// Converts the given object to <see cref="VARIANT"/>. WARNING: Only handles <see cref="string"/>. | |||
| /// Converts the given object to <see cref="VARIANT"/>. | |||
| /// </summary> | |||
| public static VARIANT FromObject(object? value) | |||
There was a problem hiding this comment.
Personal question for my better personal understanding:
Is this for the VARIANT type that has been used in the context of VB6?
If yes, there once was a DBNull subtype also, if I (vaguely) remember correctly (and I can be completely wrong). I am just mentioning it, and maybe it needs to be taken into consideration?
There was a problem hiding this comment.
Yes, there is a special null type. It's "handled" for the moment in that we fall back to the .NET interop conversion here. What we have to do is get the rest of this implemented on our side for AOT purposes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PropertyBags now serialize without it where possible. This allows a standard Control to completely serialize without the BinaryFormatter enabled.
For the AxHost case, I've left the BinaryFormatter as a fall-back.
I've also extended the Hashtable serialization to handle all primitive types. Note the two line change to make this happen. :)
This change also moves the "Reader" methods to "BinaryFormattedObjectExtensions". Due to our layering and the need to check multiple states I realized that we need to have all of the reading of objects directly using an existing BinaryFormattedObject instance.
Fixes a few bugs and adds more tests. Some random cleanup related to VARIANT (as I was exploring the scope of things).
Microsoft Reviewers: Open in CodeFlow