Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Workspaces nuget packages with compiler only packages #8389

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Dec 15, 2022

Fixes #8387 - Replace Workspaces nuget packages with compiler only packages

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner December 15, 2022 02:53
@ghost ghost assigned elachlan Dec 15, 2022
@elachlan
Copy link
Contributor Author

elachlan commented Dec 15, 2022

CC: @Youssef1313

@elachlan
Copy link
Contributor Author

elachlan commented Dec 15, 2022

We should probably move to the compilers nuget package. But I figure the team might want the flexibility to update each one individually.

…isVisualBasicPackageVersion

Use PackageVersion variables from Versions.props in Projects where appropriate
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreddy-work
Copy link
Member

We should probably move to the compilers nuget package. But I figure the team might want the flexibility to update each one individually.

I am not sure how consistent they are with versioning. For now, we can keep it this way.

@dreddy-work dreddy-work enabled auto-merge (squash) January 3, 2023 18:01
@elachlan
Copy link
Contributor Author

elachlan commented Jan 3, 2023

@dreddy-work sounds good. The tests failures here are flaky.

@dreddy-work
Copy link
Member

/AZP run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dreddy-work dreddy-work merged commit 7beb876 into dotnet:main Jan 4, 2023
@ghost ghost added this to the 8.0 Preview1 milestone Jan 4, 2023
@elachlan elachlan deleted the Analyzer-Workspaces branch January 5, 2023 22:31
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyzer projects shouldn't have a dependency on Workspaces
3 participants