Convert Shlwapi interop code to CSWin32 #7839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually most APIs have a length output which makes it possible to quickly ascertain the required length. But some don't and require using a loop and |
elachlan
force-pushed
the
cswin32-shlwapi
branch
3 times, most recently
from
2048fb2 to
e3a29fb
Compare
|
@RussKie There is a failure based on the CI image The test failures I am unsure if they are related or flaky tests? |
|
No, the CMake is related to the build images and the tooling available in those. The failure was caused by a flaky test. |
lonitra
reviewed
Sep 26, 2022
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs
Outdated
Show resolved
Hide resolved
elachlan
force-pushed
the
cswin32-shlwapi
branch
from
e3a29fb to
9593799
Compare
lonitra
reviewed
Sep 27, 2022
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
elachlan
force-pushed
the
cswin32-shlwapi
branch
from
9593799 to
f5150d8
Compare
elachlan
force-pushed
the
cswin32-shlwapi
branch
from
f5150d8 to
e997a9b
Compare
v-elnovikova
pushed a commit
to v-elnovikova/winforms
that referenced
this pull request
Oct 18, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7445
I am unsure on the
SHLoadIndirectStringchanges and would love some feedback.In MSBuild, we started with a smaller buffer and looped making it larger if the call failed. Also used
ArrayPoolin some spots. I guess it really depends on how large the returned information can technically get.dotnet/msbuild#7186
Microsoft Reviewers: Open in CodeFlow