Option to not use WebRequest for PictureBox

src/System.Windows.Forms/src/ILLink.Substitutions.xml

@@ -0,0 +1,10 @@
+<linker>
+	<assembly fullname="System.Windows.Forms">
+		<!-- System.Windows.Forms.PictureBox.UseWebRequest enables downloading images from network. It is enabled by default. -->
+		<type fullname="System.Windows.Forms.PictureBox" feature="System.Windows.Forms.PictureBox.UseWebRequest" featurevalue="false">
+			<method signature="System.Boolean UseWebRequest()" body="stub" value="false" />
+			<method signature="System.Void StartLoadViaWebRequest()" body="stub" />
+			<method signature="System.Void LoadImageViaWebClient()" body="stub" />
+		</type>
+	</assembly>
+</linker>

src/System.Windows.Forms/src/Resources/SR.resx

@@ -4534,6 +4534,9 @@ Stack trace where the illegal operation occurred was:
   <data name="PictureBoxWaitOnLoadDescr" xml:space="preserve">
     <value>Controls whether processing will stop until the image is loaded.</value>
   </data>
+  <data name="PictureBoxRemoteLocationNotSupported" xml:space="preserve">
+    <value>Loading from remote location not supported.</value>
+  </data>
   <data name="PopupControlBadParentArgument" xml:space="preserve">
     <value>Cannot set the ParentPopup to be yourself.</value>
   </data>

src/System.Windows.Forms/src/System.Windows.Forms.csproj

@@ -52,6 +52,9 @@
     <EmbeddedResource Update="Resources\System\Windows\Forms\PrintPreviewDialog.resx">
       <LogicalName>System.Windows.Forms.PrintPreviewDialog.resources</LogicalName>
     </EmbeddedResource>
+    <EmbeddedResource Include="ILLink.Substitutions.xml">
+      <LogicalName>ILLink.Substitutions.xml</LogicalName>
+    </EmbeddedResource>
   </ItemGroup>
 
   <ItemGroup>

src/System.Windows.Forms/src/System/Windows/Forms/PictureBox.cs

@@ -26,6 +26,8 @@ namespace System.Windows.Forms
     [SRDescription(nameof(SR.DescriptionPictureBox))]
     public partial class PictureBox : Control, ISupportInitialize
     {
+        private static readonly bool s_useWebRequest = AppContext.TryGetSwitch("System.Windows.Forms.PictureBox.UseWebRequest", out bool useWebRequest) ? useWebRequest : true;
+
         /// <summary>
         ///  The type of border this control will have.
         /// </summary>
@@ -466,26 +468,25 @@ public void Load()
             // false to prevent subsequent attempts.
             _pictureBoxState[NeedToLoadImageLocationState] = false;
 
-            Image img;
-            ImageInstallationType installType = ImageInstallationType.FromUrl;
             try
             {
                 DisposeImageStream();
-
-                Uri uri = CalculateUri(_imageLocation);
-                if (uri.IsFile)
+                if (UseWebRequest())
                 {
-                    _localImageStreamReader = new StreamReader(uri.LocalPath);
-                    img = Image.FromStream(_localImageStreamReader.BaseStream);
+                    LoadImageViaWebClient();
                 }
                 else
                 {
-#pragma warning disable SYSLIB0014 // Type or member is obsolete
-                    using (WebClient wc = new WebClient())
-#pragma warning restore SYSLIB0014 // Type or member is obsolete
+                    Uri uri = CalculateUri(_imageLocation);
+                    if (uri.IsFile)
+                    {
+                        _localImageStreamReader = new StreamReader(uri.LocalPath);
+                        Image img = Image.FromStream(_localImageStreamReader.BaseStream);
+                        InstallNewImage(img, ImageInstallationType.FromUrl);
+                    }
+                    else
                     {
-                        _uriImageStream = wc.OpenRead(uri.ToString());
-                        img = Image.FromStream(_uriImageStream);
+                        throw new NotSupportedException(SR.PictureBoxRemoteLocationNotSupported);
                     }
                 }
             }
@@ -498,12 +499,32 @@ public void Load()
                 else
                 {
                     // In design mode, just replace with Error bitmap.
-                    img = ErrorImage;
-                    installType = ImageInstallationType.ErrorOrInitial;
+                    InstallNewImage(ErrorImage, ImageInstallationType.ErrorOrInitial);
+                }
+            }
+        }
+
+        private void LoadImageViaWebClient()
+        {
+            Image img;
+            Uri uri = CalculateUri(_imageLocation);
+            if (uri.IsFile)
+            {
+                _localImageStreamReader = new StreamReader(uri.LocalPath);
+                img = Image.FromStream(_localImageStreamReader.BaseStream);
+            }
+            else
+            {
+#pragma warning disable SYSLIB0014 // Type or member is obsolete
+                using (WebClient wc = new WebClient())
+#pragma warning restore SYSLIB0014 // Type or member is obsolete
+                {
+                    _uriImageStream = wc.OpenRead(uri.ToString());
+                    img = Image.FromStream(_uriImageStream);
                 }
             }
 
-            InstallNewImage(img, installType);
+            InstallNewImage(img, ImageInstallationType.FromUrl);
         }
 
         [SRCategory(nameof(SR.CatAsynchronous))]
@@ -549,7 +570,74 @@ public void LoadAsync()
             _pictureBoxState[CancellationPendingState] = false;
             _contentLength = -1;
             _tempDownloadStream = new MemoryStream();
+            if (UseWebRequest())
+            {
+                StartLoadViaWebRequest();
+            }
+            else
+            {
+                var uri = CalculateUri(_imageLocation);
+                if (uri.IsFile)
+                {
+                    LoadFromFileAsync();
+                }
+                else
+                {
+                    throw new NotSupportedException(SR.PictureBoxRemoteLocationNotSupported);
+                }
+            }
+        }
 
+        private void LoadFromFileAsync()
+        {
+            Task.Run(() =>
+            {
+                try
+                {
+                    using var stream = File.OpenRead(_imageLocation);
+                    int bytesRead = -1;
+                    do
+                    {
+                        var memory = new Memory<byte>(_readBuffer);
+                        bytesRead = await stream.ReadAsync(memory, CancellationToken.None);
+                        if (bytesRead > 0)
+                        {
+                            _totalBytesRead += bytesRead;
+                            _tempDownloadStream.Write(_readBuffer, 0, bytesRead);
+
+                            // Report progress thus far, but only if we know total length.
+                            if (_contentLength != -1)
+                            {
+                                int progress = (int)(100 * (((float)_totalBytesRead) / ((float)_contentLength)));
+                                if (_currentAsyncLoadOperation is not null)
+                                {
+                                    _currentAsyncLoadOperation.Post(_loadProgressDelegate, new ProgressChangedEventArgs(progress, null));
+                                }
+                            }
+                        }
+                        else
+                        {
+                            _tempDownloadStream.Seek(0, SeekOrigin.Begin);
+                            if (_currentAsyncLoadOperation is not null)
+                            {
+                                _currentAsyncLoadOperation.Post(_loadProgressDelegate, new ProgressChangedEventArgs(100, null));
+                            }
+                        }
+                    }
+                    while (bytesRead > 0);
+                    PostCompleted(null, false);
+                }
+                catch (Exception error)
+                {
+                    // Since this is on a non-UI thread, we catch any exceptions and
+                    // pass them back as data to the UI-thread.
+                    PostCompleted(error, false);
+                }
+            });
+        }
+
+        private void StartLoadViaWebRequest()
+        {
 #pragma warning disable SYSLIB0014 // Type or member is obsolete
             WebRequest req = WebRequest.Create(CalculateUri(_imageLocation));
 #pragma warning restore SYSLIB0014 // Type or member is obsolete
@@ -1193,5 +1281,8 @@ void ISupportInitialize.EndInit()
 
             _pictureBoxState[InInitializationState] = false;
         }
+
+        // The Linker is also capable of replacing the value of this method when the application is being trimmed.
+        private static bool UseWebRequest() => s_useWebRequest;
     }
 }