Convert the rest of System.Drawing printing to CsWin32 #10598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the rest of System.Drawing.Printing to CsWin32. - Move now-shared API to Core assembly - Update calls to PInvokeCore for said calls - Add HdcHandle for HDCs that we have to keep in fields - Move printing DeviceContext usages to scopes - Use new printer dialog to get default printer names - Remove ScreenDC and use scope
ghost
assigned 
DJm00n
reviewed
Jan 6, 2024
There was a problem hiding this comment.
Maybe you can also remove LogicalDpi from DpiHelper.cs and OneHundredPercentLogicalDpi from ScaleHelper.cs and make use of PInvoke.USER_DEFAULT_SCREEN_DPI instead?
There was a problem hiding this comment.
Thanks for pointing that out. I'll look at adding it.
lonitra
reviewed
Jan 8, 2024
| // Here, we'll check to see if we are in a terminal services session... | ||
| (((User32.GetSystemMetrics(NativeMethods.SM_REMOTESESSION) & 0x00000001) != 0) && (error == 0))) | ||
| // Here, we'll check to see if we are in a terminal services session. | ||
| (((PInvokeCore.GetSystemMetrics(SYSTEM_METRICS_INDEX.SM_REMOTESESSION) & 0x00000001) != 0) && (error == 0))) |
There was a problem hiding this comment.
Is the 0x00000001 = SYSTEM_METRICS_INDEX.SM_REMOTESESSION? Maybe we can use that to be clear here.
|
@lonitra I can address your feedback in a subsequent PR as I have a few in progress. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the rest of System.Drawing.Printing to CsWin32.
Microsoft Reviewers: Open in CodeFlow