-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start migrating UiaCore to CsWin32 #10200
Conversation
I might be wrong actually. |
Changes LGTM, thanks for doing this! 🥳 The PR mentioned above only converts enums that are related to |
It's all the enums. I didn't run through the narrator tests. |
We recently ran into an issue while converting UIA enums that metadata had defined their enums incorrectly. In that case metadata had defined enum as |
I generally check ilspy to confirm all values are in the enums. I'll make a note to check the data type as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested. Narrator seems to be announcing things correctly 🚀
Related: #7445, #9795
This is just a start, focusing on the enums. I mostly used find/replace and corrected any compile errors.
Microsoft Reviewers: Open in CodeFlow