Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The yellow rectangle is not displayed for a subitem when the user hovers over it or selects in the Inspector tree #4679

Closed
SergeySmirnov-Akvelon opened this issue Mar 12, 2021 · 1 comment · Fixed by #4761
Closed

The yellow rectangle is not displayed for a subitem when the user hovers over it or selects in the Inspector tree #4679

SergeySmirnov-Akvelon opened this issue Mar 12, 2021 · 1 comment · Fixed by #4761
Assignees
@SergeySmirnov-Akvelon
Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release

Comments

@SergeySmirnov-Akvelon
Copy link
Contributor

SergeySmirnov-Akvelon commented Mar 12, 2021 •
edited
Loading

.NET Core Version:

  • 5.0.200-preview.20614.14

Have you experienced this same bug with .NET Framework?:

Minimal repro:

  1. Create application with ListView.
  2. Set View.Tile for ListView
  3. Add couple ColumnHeaders to ListView.
  4. Add ListViewItem with ListViewSubItem to ListView.
  5. Or use attached project
  6. Run application.
  7. Run Inpsector.
  8. Select ListViewItem in Inspector.
  9. Expand ListViewItem
  10. Select ListViewSubItem.

Actual behavior:
Yellow rectangle is not displayed.
Issue-4678-issue2 - actual

Expected:
Yellow rectangle should displaye around the ListViewSubItem
Issue-4678-issue2 - expected

Note:
I think the problem is reproduced due to this condition. View.Tile view also supports displaying the first subitem
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon added 🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release labels Mar 16, 2021
Closed
9 tasks
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon self-assigned this Mar 25, 2021
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Apr 5, 2021
@RussKie RussKie added this to the 6.0 milestone Apr 14, 2021
SergeySmirnov-Akvelon added a commit to SergeySmirnov-Akvelon/winforms that referenced this issue May 12, 2021
@SergeySmirnov-Akvelon
Fix The yellow rectangle is not displayed for a subitem when the user…
a7d78da 
… hovers over it or selects in the Inspector tree dotnet#4679

Changed the logic for getting ListViewSubItems for the Inspector tree.
Now they are not displayed for "List", "SmallIcon", "Large" views.
For "Tile" view, we display the ListViewSubItems in the Inspector tree based on the number of ListViewSubItems, the number of ListViewColumns and the "Bounds" property, through which we know that the ListViewSubItem is visible.
For "Details" view, we display ListViewSubItems based on the number of ListViewColumns. If the cell is visible and the ListViewSubItems does not exist, we create a fake ListViewSubItemsAccessibleObject for that cell.

Fixed the issue with getting a rectangle for ListViewSubItem when the ListView is in "Tile" view

Added missing conditions
Added unit and MAUI tests
@ghost ghost closed this as completed in #4761 May 13, 2021
ghost pushed a commit that referenced this issue May 13, 2021
@SergeySmirnov-Akvelon
Fix incorrect behavior of ListViewSubItem (#4761)
3982fa0 
Fixes #4679 


## Proposed changes
- Changed the logic for getting `ListViewSubItems` for the Inspector tree: 
  * Now they are not displayed for `List`, `SmallIcon`, `Large` views.
  * For `Tile` view, we display the `ListViewSubItems` in the Inspector  tree based on the number of `ListViewSubItems`, the number of `ListViewColumns` and the `Bounds` property, through which we know that the `ListViewSubItem` is visible.
  * For `Details` view, we display `ListViewSubItems` based on the number of `ListViewColumns`. If the cell is visible and the `ListViewSubItems`  does not exist, we create a fake `ListViewSubItemsAccessibleObject` for that cell.
- Fixed the issue with getting a rectangle for `ListViewSubItem` when the `ListView` is in `Tile` view
- Added missing conditions
- Added unit and MAUI tests

## Customer Impact
<details>
<summary> Details view </summary>

**Before fix:**
![Issue-46749_before_Details](https://user-images.githubusercontent.com/23376742/113559134-88449480-9609-11eb-9b30-0d70878b76b2.png)

**After fix:**
![Issue-46749_after_Details](https://user-images.githubusercontent.com/23376742/113559151-909ccf80-9609-11eb-848a-c1dcadb09b55.png)

</details>

<details>
<summary> LargeIcon view </summary>

**Before fix:**
![Issue-46749_before_LargeIcon](https://user-images.githubusercontent.com/23376742/113559193-9f838200-9609-11eb-8402-3998002e84ff.png)

**After fix:**
![Issue-46749_after_LargeIcon](https://user-images.githubusercontent.com/23376742/113559207-a611f980-9609-11eb-8102-e2aa5606bdec.png)

</details>

<details>
<summary> List view </summary>

**Before fix:**
![Issue-46749_before_List](https://user-images.githubusercontent.com/23376742/113559245-b1fdbb80-9609-11eb-814f-5c9143d9ca2f.png)

**After fix:**
![Issue-46749_after_List](https://user-images.githubusercontent.com/23376742/113559259-b629d900-9609-11eb-86fc-363937418750.png)

</details>

<details>
<summary> SmallIcon view </summary>

**Before fix:**
![Issue-46749_before_SmallIcon](https://user-images.githubusercontent.com/23376742/113559267-b9bd6000-9609-11eb-8b10-cd06ae296d6d.png)

**After fix:**
![Issue-46749_after_SmallIcon](https://user-images.githubusercontent.com/23376742/113559281-bf1aaa80-9609-11eb-9a9b-9d92422781cb.png)

</details>

<details>
<summary> Tile view </summary>

**Before fix:**
![Issue-46749_before_Tile](https://user-images.githubusercontent.com/23376742/113559295-c5108b80-9609-11eb-8a84-d65618e06ef8.png)

**After fix:**
![Issue-46749_after_Tile](https://user-images.githubusercontent.com/23376742/113559311-cb066c80-9609-11eb-9ab2-249cb54eac85.png)

</details>


## Regression? 

- Yes

## Risk

- Minimal

<!-- end TELL-MODE -->


## Test methodology <!-- How did you ensure quality? -->
- CTI team 
- Unit tests
- MAUI tests

## Accessibility testing  <!-- Remove this section if PR does not change UI -->
- Narrator
- Inspector
 
## Test environment(s) <!-- Remove any that don't apply -->
- Microsoft Windows [Version 10.0.19041.388]
- .NET Core SDK: 6.0.0-preview.2.21154.2
@ghost ghost removed the 🚧 work in progress Work that is current in progress label May 13, 2021
@RussKie RussKie removed this from the 6.0 milestone May 17, 2021
@Marie-Shi
Copy link

Verified this issue with 6.0.100-preview.5.21276.14 from Release/6.0.1XX-preview5 branch of https://github.com/dotnet/installer, it is fixed, now Yellow rectangle displays around the ListViewSubItem.
fix

@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon

Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect behavior of ListViewSubItem SergeySmirnov-Akvelon/winforms
3 participants
@RussKie @SergeySmirnov-Akvelon @Marie-Shi