changes from review

dotnet · Jan 26, 2023 · deeae48 · deeae48
1 parent b68076b
commit deeae48
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt b/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt
@@ -636,7 +636,7 @@ virtual System.ComponentModel.Design.DesignerCommandSet.GetCommands(string! name
 ~virtual System.ComponentModel.Design.Serialization.CodeDomSerializer.SerializeMemberAbsolute(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, object owningObject, System.ComponentModel.MemberDescriptor member) -> System.CodeDom.CodeStatementCollection
 ~virtual System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer.SerializeCollection(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeExpression targetExpression, System.Type targetType, System.Collections.ICollection originalCollection, System.Collections.ICollection valuesToSerialize) -> object
 virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateInstance(System.Type! type, System.Collections.ICollection? arguments, string? name, bool addToContainer) -> object!
-virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type? serviceType) -> object?
+virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type! serviceType) -> object?
 virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetType(string? typeName) -> System.Type?
 virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnResolveName(System.ComponentModel.Design.Serialization.ResolveNameEventArgs! e) -> void
 virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionCreated(System.EventArgs! e) -> void

diff --git a/...rms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs b/...rms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs
@@ -524,7 +524,7 @@ public IDisposable CreateSession()
         /// <summary>
         ///  Provides access to the underlying IServiceProvider
         /// </summary>
-        protected virtual object? GetService(Type? serviceType)
+        protected virtual object? GetService(Type serviceType)
             => serviceType == typeof(IContainer) ? Container : provider?.GetService(serviceType);
 
         /// <summary>