Include tooltip to Razor provisional completion

[jordi1215]

This resolves #7250. The cause was that when we added a provisional dot to the generated virtual csharp document, the change didn't get reflected on disk before the Roslyn server took the completion request.

Changes made in completionHandler.ts:

1. Made changes so that both provisional and non-provisional code completion uses the same provideCompletionsCommand (roslyn.provideCompletions).
2. On top of adding a temporary provisional dot "." after each provisional completion request, we are adding a "resolve" provisional dot for each resolve completion request. The dot is essential for the resolve request to be correct and therefor for the tooltip to show up.
3. Use vscode.workspace.onDidChangeTextDocument to ensure that the virtual documents get updated before sending the request to the roslyn server for both completion and resolve completion requests.

Before

What could have gone wrong if it wasn't for David's comment

Screen.Recording.2024-08-14.at.3.23.43.PM.mov

After

Screen.Recording.2024-08-15.at.9.45.26.AM.mov

[davidwengier]

The documentation gets synced afterwards

This is only if the completion is actually taken, right? Do things still work correctly otherwise? eg, type DateTime., press ESC to dismiss completion, and then scroll the text into view and out of view, or hover over something etc. I would expect not cleaning up the . would cause disco colors etc.

TL;DR, If the Razor document doesn't change after typing the dot, presumably the generated document never gets re-synced

[jordi1215]

The documentation gets synced afterwards

This is only if the completion is actually taken, right? Do things still work correctly otherwise? eg, type DateTime., press ESC to dismiss completion, and then scroll the text into view and out of view, or hover over something etc. I would expect not cleaning up the . would cause disco colors etc.

TL;DR, If the Razor document doesn't change after typing the dot, presumably the generated document never gets re-synced

Thanks for the heads up! I did manage to get it into a "bad" state. Assuming var name="Jordi", @name. will trigger completion. If nothing gets accepted then C# will think it is an incomplete statement and give the red squiggles whereas HTML will interpret it as Jordi..

I think I will try add and remove the provisional dot for both completion and resolveCompletion command.

Thanks so much!

[davidwengier]

I agree with Andrew, it would be much better if we can hook the didChange rather than use a delay. The rest makes sense, though I must admit I find this whole area confusing and hard to reason about. Could just be my TypeScript skills :)

[davidwengier]

Perhaps this field should be cleared in addProvisionalDotAt, just to ensure the previous resolve index doesn't stick around?

[jordi1215]

The problem here is right now the resolve completion request doesn't know whether the completion request was provisional or not. So one bad state could be:
-> (Provisional completion) user triggers provisional completion
-> (resolve completion) provisional dot are added and removed as the user toggles completion list
-> (regular completion) as the user continues to type, completion list shows up
-> (resolve completion) provisional dot are added and removed still since the field is not cleared