Add grammar support for new directives: rendermode, preservewhitespace and typeparam #6887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added grammar support for rendermode, preservewhitespace and typeparam in tmLanguage.yml - populated the corresponding json file with the npm run compile:razorTextMate command - added the corresponding tests in Microsoft.AspNetCore.Razor.VSCode.Grammar.Test
- added the snapshot for the three new added grammar tests: rendermode, preservewhitespace and typeparam. The snapshot is verified to be correct with all the token correctly identified. In the future, subsequent tests will be tested against these created snapshots.
There was a problem hiding this comment.
addresses an dotnet/razor#9882 in the razor repository
GitHub Pro-tip, if you include the word "fixes" or "closes" immediately before an issue number, then GitHub will automatically close the issue when the PR merges.
test/razorTests/Microsoft.AspNetCore.Razor.VSCode.Grammar.Test/tests/typeparamDirective.ts
Show resolved
Hide resolved
- since only "true" or "false" are expected after "preservewhitespace", the grammar should color the boolean-literal accordingly
added a few more tests for completeness
davidwengier
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes dotnet/razor#9882 in the razor repository. It updates the TextMate grammar to include code coloring for three new Razor directives: rendermode, preservewhitespace, and typeparam. You can find more information about these directives in the razor documentation.
Changes Summary
tmLanguage.yml
This file defines the TextMate grammar. I added support for the three new Razor directives, following the same format as the existing directives.
tmLanguage.json
This file is automatically generated to reflect the changes in tmLanguage.yml. You can update it by running the razorTests or the
npm run compile:razorTextMatecommand.razorTests
I added three new entries in grammarTests.test.ts and created three new test files for the new directives. These tests follow the same format as the existing tests for other Razor directives.
Visualization
Before
After