Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET: Restore Packages command should work with .NET Core .csproj projects #1176

Merged

Conversation

DustinCampbell
Copy link
Member

fixes #1175

@DustinCampbell DustinCampbell added this to the 1.7 milestone Feb 3, 2017
}

export function findNetCoreAppTargetFramework(project: MSBuildProject): TargetFramework {
return project.TargetFrameworks.find(tf => tf.ShortName.startsWith('netcoreapp'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also be netstandard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grumble yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@DustinCampbell DustinCampbell force-pushed the fix-dotnet-restore-command branch from d1ed6a7 to 214c6cd Compare February 3, 2017 13:09
@DustinCampbell
Copy link
Member Author

Grr... That 'netstandard' "fix" I made will break other things. Fixing again and force-pushing.

@DustinCampbell DustinCampbell merged commit 4ba9941 into dotnet:master Feb 3, 2017
@filipw
Copy link
Contributor

filipw commented Feb 3, 2017

great, looking forward to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'dotnet: Restore Packages' VS Code command does not work
3 participants