Skip to content

Commit

Permalink
Report sdk style project information
Browse files Browse the repository at this point in the history
  • Loading branch information
dibarbet committed Jan 31, 2023
1 parent 5b9a5a1 commit eceefa8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/observers/TelemetryObserver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export class TelemetryObserver {
telemetryProps['FileCounts'] = projectConfig.FileCounts?.join("|") ?? "";
telemetryProps['NetSdkVersion'] = this.dotnetInfo?.Version ?? "";
telemetryProps['useModernNet'] = this.useModernNet.toString();
telemetryProps['sdkStyleProject'] = projectConfig.SdkStyleProject.toString();
this.reporter.sendTelemetryEvent("ProjectConfiguration", telemetryProps);
}

Expand Down
1 change: 1 addition & 0 deletions src/omnisharp/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ export interface ProjectConfigurationMessage {
References: string[];
FileExtensions: string[];
FileCounts: number[];
SdkStyleProject: boolean;
}

export interface PackageDependency {
Expand Down
9 changes: 7 additions & 2 deletions test/unitTests/logging/TelemetryObserver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ suite('TelemetryReporterObserver', () => {
let property: { [key: string]: string } = null;
let measure: { [key: string]: number }[] = [];
let errorProp: string[][] = [];
let useModernNet = true;
let observer = new TelemetryObserver(platformInfo, () => {
return {
...getNullTelemetryReporter,
Expand All @@ -35,7 +36,7 @@ suite('TelemetryReporterObserver', () => {
errorProp.push(errorProps);
},
};
});
}, useModernNet);

setup(() => {
name = "";
Expand Down Expand Up @@ -66,6 +67,7 @@ suite('TelemetryReporterObserver', () => {
const references = ["ref1", "ref2"];
const fileExtensions = [".cs", ".cshtml"];
const fileCounts = [7, 3];
const sdkStyleProject = true;
let event = new ProjectConfiguration({
ProjectCapabilities: projectCapabilities,
TargetFrameworks: targetFrameworks,
Expand All @@ -74,7 +76,8 @@ suite('TelemetryReporterObserver', () => {
OutputKind: outputKind,
References: references,
FileExtensions: fileExtensions,
FileCounts: fileCounts
FileCounts: fileCounts,
SdkStyleProject: sdkStyleProject
});

observer.post(event);
Expand All @@ -86,6 +89,8 @@ suite('TelemetryReporterObserver', () => {
expect(property["References"]).to.be.equal("ref1|ref2");
expect(property["FileExtensions"]).to.be.equal(".cs|.cshtml");
expect(property["FileCounts"]).to.be.equal("7|3");
expect(property["useModernNet"]).to.be.equal("true");
expect(property["sdkStyleProject"]).to.be.equal("true");
});

[
Expand Down

0 comments on commit eceefa8

Please sign in to comment.