-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for creating diagnostics for general API usage #685
Conversation
...icrosoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers.Common/SyntaxNodeExtensions.cs
Outdated
Show resolved
Hide resolved
...analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/ApiAlertAnalyzer.cs
Outdated
Show resolved
Hide resolved
...analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/ApiAlertAnalyzer.cs
Outdated
Show resolved
Hide resolved
...analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/ApiAlertAnalyzer.cs
Outdated
Show resolved
Hide resolved
...alyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/DefaultApiAlerts.json
Outdated
Show resolved
Hide resolved
...alyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/DefaultApiAlerts.json
Outdated
Show resolved
Hide resolved
...ault/analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/NameMatcher.cs
Show resolved
Hide resolved
...ult/analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/TargetSyntax.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/TargetSyntaxMessageLoader.cs
Outdated
Show resolved
Hide resolved
@twsouthwick, I've updated the PR based on your feedback (thanks!). Can you take another look? Also, I removed launchSettings.json which it looks like you added last week but I think is unnecessary since I don't want to have a git change (or, worse, conflict) every time I f5 UA against a different project locally. Let me know if there's a reason you prefer committing the file. |
The launchsettings.json change was so it would get launched with "development" enviornment so it won't send telemetry on dev work. Happy to explore other options there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but otherwise LGTM
As for the localizability, I'm fine punting that, but we should identify any architectural choices to make sure we won't cause breaking changes to introduce it.
...s/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/DefaultApiAlerts.apitargets
Show resolved
Hide resolved
.../Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers/TargetSyntaxMessageLoader.cs
Show resolved
Hide resolved
Yea, I see why you changed launchsettings.json. I'll change it back to how you had it. I don't like having that file be always modified (and never committed) on my dev machine, but I can't think of a better alternative. |
This adds an analyzer (without code fix provider) for identifying and flagging usage of configured namespaces, types, or members and creating diagnostics with associated messages.
This will allow easily notifying users if they're using namespace, types, or members that are known to require manual changes.
Fixes #621
Fixes #502
Fixes #65
Fixes #69
Fixes #75