Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure for creating diagnostics for general API usage #685

Merged
merged 15 commits into from
Jul 21, 2021

Conversation

mjrousos
Copy link
Member

@mjrousos mjrousos commented Jul 2, 2021

This adds an analyzer (without code fix provider) for identifying and flagging usage of configured namespaces, types, or members and creating diagnostics with associated messages.

This will allow easily notifying users if they're using namespace, types, or members that are known to require manual changes.

Fixes #621
Fixes #502
Fixes #65
Fixes #69
Fixes #75

@mjrousos mjrousos requested a review from a team as a code owner July 2, 2021 15:35
@mjrousos
Copy link
Member Author

@twsouthwick, I've updated the PR based on your feedback (thanks!). Can you take another look?

Also, I removed launchSettings.json which it looks like you added last week but I think is unnecessary since I don't want to have a git change (or, worse, conflict) every time I f5 UA against a different project locally. Let me know if there's a reason you prefer committing the file.

@mjrousos mjrousos requested a review from twsouthwick July 16, 2021 20:20
@twsouthwick
Copy link
Member

The launchsettings.json change was so it would get launched with "development" enviornment so it won't send telemetry on dev work. Happy to explore other options there

Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but otherwise LGTM

As for the localizability, I'm fine punting that, but we should identify any architectural choices to make sure we won't cause breaking changes to introduce it.

@mjrousos
Copy link
Member Author

Yea, I see why you changed launchsettings.json. I'll change it back to how you had it. I don't like having that file be always modified (and never committed) on my dev machine, but I can't think of a better alternative.

@mjrousos mjrousos merged commit dba07c7 into main Jul 21, 2021
@mjrousos mjrousos deleted the mjrousos/621 branch July 21, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment