Miscellaneous improvements in System.Text.* #816
Conversation
terrajobst
added
the
netstandard-api
| @@ -90,9 +147,6 @@ public partial class Regex : System.Runtime.Serialization.ISerializable | |||
| public System.TimeSpan MatchTimeout { get { throw null; } } | |||
| public System.Text.RegularExpressions.RegexOptions Options { get { throw null; } } | |||
| public bool RightToLeft { get { throw null; } } | |||
| //REFEMIT public static void CompileToAssembly(System.Text.RegularExpressions.RegexCompilationInfo[] regexinfos, System.Reflection.AssemblyName assemblyname) { } | |||
| //REFEMIT public static void CompileToAssembly(System.Text.RegularExpressions.RegexCompilationInfo[] regexinfos, System.Reflection.AssemblyName assemblyname, System.Reflection.Emit.CustomAttributeBuilder[] attributes) { } | |||
| //REFEMIT public static void CompileToAssembly(System.Text.RegularExpressions.RegexCompilationInfo[] regexinfos, System.Reflection.AssemblyName assemblyname, System.Reflection.Emit.CustomAttributeBuilder[] attributes, string resourceFile) { } | |||
There was a problem hiding this comment.
This removal of the comment looks like a bug. I'll add them back.
This is reference assembly, not implementation assembly. Binary serialization attributes do not matter in reference assemblies. Removing the attribute here is perfectly fine; it is not a breaking change. |
I agree I was actually point out to @ViktorHofer that the breaking change is in .NET Core as that attribute doesn't exist in the implementation. |
Binary serialization is not supported for RegEx in .NET Core (https://docs.microsoft.com/en-us/dotnet/standard/serialization/binary-serialization#serializable-types). It is by design that this attribute is missing in .NET Core. |
|
You are absolutely right... |
terrajobst
force-pushed
the
system-text
branch
from
4a1a264 to
06c0b3a
Compare
Fixes #847
@dotnet/nsboard