Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant SourceBuildTrimNetFrameworkTargets property #3503

Closed
NikolaMilosavljevic opened this issue Jun 13, 2023 · 3 comments · Fixed by NuGet/NuGet.Client#5278
Closed
Assignees
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Jun 13, 2023

We have originally added SourceBuildTrimNetFrameworkTargets property to most .NET repos to enable TFM trimming, in accordance with the original design: #3014

As a consequence, the following line was added to those repos (an example from installer):

https://github.com/dotnet/installer/blob/f8275a0edc0a90b593f2e3f73c4b9b3e908e3e22/eng/SourceBuild.props#LL8C50-L8C50

    <SourceBuildTrimNetFrameworkTargets>true</SourceBuildTrimNetFrameworkTargets>

After original implementation, TFM trimming work was further simplified, to use the opt-out logic, with: dotnet/arcade#13271

This property is not needed anymore, it causes unnecessary confusion and increased maintenance cost. Property should be removed at the earliest convenience.

To ensure proper tracking, for each repo, the list below should be updated with the PR link. Refer to original work (#3014) for the full list of repos and original changes. Note that some repos never used this property, i.e. emsdk and runtime.

Repositories

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons moved this from Backlog to 8.0 Preview 7 in .NET Source Build Jun 22, 2023
@MichaelSimons MichaelSimons added area-upstream-fix Needs a change in a contributing repo and removed untriaged labels Jun 22, 2023
@MichaelSimons
Copy link
Member

[Triage] @v-chayan, please work with @NikolaMilosavljevic to gain an understanding of the changes needed here.

This was referenced Jun 25, 2023
@MichaelSimons
Copy link
Member

All PRs have been completed! Closing.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants