-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant SourceBuildTrimNetFrameworkTargets
property
#3503
Closed
Labels
area-upstream-fix
Needs a change in a contributing repo
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
MichaelSimons
added
area-upstream-fix
Needs a change in a contributing repo
and removed
untriaged
labels
Jun 22, 2023
[Triage] @v-chayan, please work with @NikolaMilosavljevic to gain an understanding of the changes needed here. |
This was referenced Jun 25, 2023
All PRs have been completed! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have originally added
SourceBuildTrimNetFrameworkTargets
property to most .NET repos to enable TFM trimming, in accordance with the original design: #3014As a consequence, the following line was added to those repos (an example from
installer
):https://github.com/dotnet/installer/blob/f8275a0edc0a90b593f2e3f73c4b9b3e908e3e22/eng/SourceBuild.props#LL8C50-L8C50
After original implementation, TFM trimming work was further simplified, to use the opt-out logic, with: dotnet/arcade#13271
This property is not needed anymore, it causes unnecessary confusion and increased maintenance cost. Property should be removed at the earliest convenience.
To ensure proper tracking, for each repo, the list below should be updated with the PR link. Refer to original work (#3014) for the full list of repos and original changes. Note that some repos never used this property, i.e.
emsdk
andruntime
.Repositories
The text was updated successfully, but these errors were encountered: