-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dotnet SDK to support targeting android-arm64/x64 with CoreCLR #46325
Enable dotnet SDK to support targeting android-arm64/x64 with CoreCLR #46325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just to clarify, to resolve CoreCLR packages for Android the mobile SDK/customer's project needs to have UseMonoRuntime != true
My understanding is that this is the default behavior, and this change only includes Android in the supported runtime pack RIDs. Let me try to verify that. |
What I meant to say is that:
so to escape that Android SDK (or our internal testing) must not set this property. Just wanted to clear that up / emphasise it. Sorry for the confusion! |
@dsplaisted Could we proceed and merge? The failures are not related. |
Description
This PR adds
android-arm64
andandroid-x64
rids to theNetCoreRuntimePackRids
to support targeting Android with CoreCLR.The CoreCLR Android runtime packs are introduced in dotnet/runtime#110471.
Out of scope
This PR doesn't include
android-arm
,android-x86
, and NativeAOT support. The follow-up work is tracked in dotnet/runtime#111491