Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dotnet SDK to support targeting android-arm64/x64 with CoreCLR #46325

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

kotlarmilos
Copy link
Member

Description

This PR adds android-arm64 and android-x64 rids to the NetCoreRuntimePackRids to support targeting Android with CoreCLR.

The CoreCLR Android runtime packs are introduced in dotnet/runtime#110471.

Out of scope

This PR doesn't include android-arm, android-x86, and NativeAOT support. The follow-up work is tracked in dotnet/runtime#111491

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 27, 2025
@kotlarmilos kotlarmilos self-assigned this Jan 27, 2025
@kotlarmilos kotlarmilos added this to the 10.0.1xx milestone Jan 27, 2025
Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just to clarify, to resolve CoreCLR packages for Android the mobile SDK/customer's project needs to have UseMonoRuntime != true

@kotlarmilos
Copy link
Member Author

resolve CoreCLR packages for Android the mobile SDK/customer's project needs to have UseMonoRuntime != true

My understanding is that this is the default behavior, and this change only includes Android in the supported runtime pack RIDs. Let me try to verify that.

@ivanpovazan
Copy link
Member

What I meant to say is that:

  • if UseMonoRuntime=true (which is the default for targeting android) the SDK will use Mono runtime packs for framework resolution:
    <FrameworkReference Update="Microsoft.NETCore.App"
    RuntimePackLabels="Mono"
    Condition="'$(UseMonoRuntime)' == 'true' And ('$(_TargetFrameworkVersionWithoutV)' != '') And ('$(_TargetFrameworkVersionWithoutV)' >= '6.0')" />

so to escape that Android SDK (or our internal testing) must not set this property.

Just wanted to clear that up / emphasise it. Sorry for the confusion!

@kotlarmilos
Copy link
Member Author

@dsplaisted Could we proceed and merge? The failures are not related.

@akoeplinger akoeplinger merged commit 6d969b6 into dotnet:main Jan 29, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants