Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from nuget/nuget.client #46290

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from nuget/nuget.client #46290

wants to merge 16 commits into from
+49 −108

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 25, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Subscription: fcb199f6-ff33-44a0-f3ef-08d8e97c775d
  • Build: 6.14.0.17
  • Date Produced: January 29, 2025 9:40:56 PM UTC
  • Commit: 4ccad7689eaf96f30d41709369bebc888e4a5db3
  • Branch: dev

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
c5067c9 
…6.14.0.12

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.14.0-preview.1.11 -> To Version 6.14.0-preview.1.12
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jan 25, 2025
This was referenced Jan 25, 2025
Open
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
61097a0 
…6.14.0.13

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.14.0-preview.1.11 -> To Version 6.14.0-preview.1.13
This was referenced Jan 25, 2025
Open
Open
Open
Open
@v-wuzhai v-wuzhai requested review from ViktorHofer and a team January 26, 2025 10:04
@NikolaMilosavljevic
Copy link
Member

Source-build is failing with CSC : error CS8002: Referenced assembly 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. [/__w/1/vmr/src/nuget-client/src/NuGet.Core/NuGet.CommandLine.XPlat/NuGet.CommandLine.XPlat.csproj]

This is presumably a new assembly. Any reason why it doesn't have a strong name? @baronfel this dependency was added 3 days ago with NuGet/NuGet.Client#6219

Also, which repo is supposed to build this library from source? Current failure is in online build, but offline build will also fail unless new library is source-built.

@mthalman
Copy link
Member

Also, which repo is supposed to build this library from source? Current failure is in online build, but offline build will also fail unless new library is source-built.

It's built from SBE: https://github.com/dotnet/source-build-externals/blob/main/repo-projects/vs-solutionpersistence.proj

@NikolaMilosavljevic
Copy link
Member

Microsoft.VisualStudio.SolutionPersistence library produced in source-build-externals repo doesn't have a valid strong-name unlike the library produced in official builds of that repo, and available on nuget.org.

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
111ac82 
…6.14.0.14

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.14.0-preview.1.11 -> To Version 6.14.0-preview.1.14
@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Jan 28, 2025 •
edited
Loading

Microsoft.VisualStudio.SolutionPersistence library produced in source-build-externals repo doesn't have a valid strong-name unlike the library produced in official builds of that repo, and available on nuget.org.

I am working on this - SBE needs to produce an assembly with valid strong-name. Original repo has the same issue with packages produced in Linux build legs.

@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Jan 28, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
922b60f 
…6.14.0.15

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.14.0-preview.1.11 -> To Version 6.14.0-preview.1.15
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Jan 29, 2025
Merged
@build-analysis build-analysis bot mentioned this pull request Jan 30, 2025
Open
@ViktorHofer ViktorHofer requested a review from a team as a code owner January 30, 2025 07:42
@ViktorHofer ViktorHofer enabled auto-merge (squash) January 30, 2025 07:43
@ViktorHofer
Copy link
Member

@premun can you please take a look at the VMR sync failures here? The patch got removed so I'm surprised that it fails.

@premun
Copy link
Member

premun commented Jan 30, 2025

Having a look. Looks like some CRLF issue again. I saw this before and the repo had some weird EOL checked in where the file was dirty even after a plain clone. I will check how the file looks and how the patch looks too.

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
851ec15 
…6.14.0.17

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.14.0-preview.1.11 -> To Version 6.14.0-preview.1.17
@premun
Copy link
Member

premun commented Jan 31, 2025

Sorry, had some live incidents for the past 2 days. Will get to it first thing on Monday

@premun premun mentioned this pull request Jan 31, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 6, 2025
Open
3 tasks
@ViktorHofer ViktorHofer mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NikolaMilosavljevic @mthalman @ViktorHofer @premun @akoeplinger