[main] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: d5dc2a0a-0871-47fc-022d-08dc4502ccaa
• Build: 20250130.6
• Date Produced: January 31, 2025 1:19:27 AM UTC
• Commit: de7b08d41e1a09e4f86c17487d4b526011ada498
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.roslyn: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.CSharp: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.CSharp.CodeStyle: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.CSharp.Features: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.CSharp.Workspaces: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.Workspaces.Common: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.CodeAnalysis.Workspaces.MSBuild: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.Net.Compilers.Toolset: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6
  • Microsoft.Net.Compilers.Toolset.Framework: from 4.14.0-1.25070.2 to 4.14.0-2.25080.6

[dotnet-maestro]

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure-current-swat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

• This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
• If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
• For more details, please read the Arcade Darc documentation

[v-wuzhai]

@dotnet/product-construction Could you take a look at the VMR failures here?

[ViktorHofer]

Compiler/Analyzer change that affects building the razor repo? Who is usually on the hook fixing those? cc @jaredpar

[jaredpar]

@ViktorHofer do we have a binlog before / after so we can diff if this is a compiler change or a subtle build change?

@DustinCampbell

[ViktorHofer]

Yes the "after" binlog is here in the pipeline artifacts from the (source-only build offline leg):

For before, take any binlog from the dotnet-source-build (internal) pipeline from the same leg and the same path.

[DustinCampbell]

@ViktorHofer do we have a binlog before / after so we can diff if this is a compiler change or a subtle build change?

@DustinCampbell

I imagine this break is related to dotnet/razor#11394, which revved the Roslyn reference to 4.14 and seems to affect Razor.Diagnostic.Analyzers. This is likely the same as #46184.

[DustinCampbell]

I imagine this break is related to dotnet/razor#11394, which revved the Roslyn reference to 4.14 and seems to affect Razor.Diagnostic.Analyzers. This is likely the same as #46184.

Actually, I think I've crossed my wires. This is a likely a different issue. 😄

[akoeplinger]

source-build is still failing:

/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Utilities/SortHelper`1.cs(104,95): error IDE0060: Parameter 'keys' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060) [/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj::TargetFramework=netstandard2.0]
/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Utilities/SortHelper`1.cs(178,96): error IDE0060: Parameter 'keys' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060) [/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj::TargetFramework=netstandard2.0]
/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Utilities/SortHelper`1.cs(104,95): error IDE0060: Parameter 'keys' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060) [/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj::TargetFramework=net10.0]
/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Utilities/SortHelper`1.cs(178,96): error IDE0060: Parameter 'keys' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060) [/__w/1/vmr/src/razor/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj::TargetFramework=net10.0]

[adamsitnik]

This PR is going to require SDK to be updated as well: #46241 which is blocked by NuGet.Client update: NuGet/NuGet.Client#6236 which is blocked by a chicken-and-egg problem, as both the NuGet and SDK rely on S.CL, but NuGet uses an SDK from Channel 9.0.2xx -Quality daily to run integration tests (and this SDK is relying on an older version of S.CL that uses different type names and causes runtime errors).

We are currently in a deadlock, as the solution suggested by the NuGet team would not work. Please see NuGet/NuGet.Client#6236 for details and feel free to share your thoughts on how to solve this problem.