-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containers telemetry #41747
Containers telemetry #41747
Conversation
…osoftDefaultImages
…r data in the same payload
Ok, I'm pretty happy with this now. We now send telemetry for container publishes for three main scenarios:
I've verified the data is allowed through the CLI's allowlist mechanisms, but haven't yet been able to verify it showing up in our telemetry systems. All telemetry adheres to the CLI's existing opt-out mechanisms and we do not long user-provided information - we only log registry, image name, and tag information when we can verify that it's using the mcr.microsoft.com base images. In all other cases that data is I'd like to get this in this week, because the 8.0.4xx freeze occurs soon. |
src/Containers/Microsoft.NET.Build.Containers/Registry/Registry.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems wise to collect this information so we can better understand customer needs. I have mostly questions but it looks good to me otherwise :)
src/Containers/Microsoft.NET.Build.Containers/Registry/HttpExtensions.cs
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs
Show resolved
Hide resolved
I've verified that the telemetry data is being sent correctly - after merge GDPR classification will need to occur to get this 'done' done. |
Fixes dotnet/sdk-container-builds#539
Adds telemetry for base image inference, container publishing, and a variety of errors that can occur along the process.