Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let runtime supply the portable RID graph #36807

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 10, 2023

@dsplaisted
Copy link
Member

It looks like tests are failing because the portable RuntimeIdentifier graph can't be found. Probably the code that creates stage 2 needs to be updated to include that file.

@ViktorHofer
Copy link
Member Author

It looks like tests are failing because the portable RuntimeIdentifier graph can't be found. Probably the code that creates stage 2 needs to be updated to include that file.

Any idea how to do that? The portable and non portable RID graphs are directly flowing from runtime -> installer and bundled into the SDK there.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jan 10, 2024

@dsplaisted can you please help with this change? I'm currently quite busy with the VMR work and I think we should finish this work before .NET 9 Preview 1.

@ViktorHofer ViktorHofer reopened this Jan 11, 2024
@kasperk81
Copy link
Contributor

<RuntimeIdentifierGraphPath>$([System.IO.Path]::GetDirectoryName($(BundledRuntimeIdentifierGraphFile)))/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>

<RuntimeIdentifierGraphPath Condition="'$(UseRidGraph)' != 'true'">$([System.IO.Path]::GetDirectoryName($(BundledRuntimeIdentifierGraphFile)))/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>

these two needed?

@ViktorHofer
Copy link
Member Author

these two needed?

Those properties in the sdk are needed, yes.

@ViktorHofer ViktorHofer enabled auto-merge (squash) July 8, 2024 20:33
@ViktorHofer ViktorHofer merged commit 0421af6 into main Jul 8, 2024
37 checks passed
@ViktorHofer ViktorHofer deleted the UsePortableRIDGraphFromRuntime branch July 8, 2024 21:23
@xen0n
Copy link

xen0n commented Jul 11, 2024

Hi, apparently this change broke this doc page by accident? As the PortableRuntimeIdentifierGraph.json was removed here.

@akoeplinger
Copy link
Member

Thanks, we need to fix the doc page.

@ViktorHofer
Copy link
Member Author

Submitted dotnet/docs#41729

akoeplinger pushed a commit to dotnet/docs that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants