-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let runtime supply the portable RID graph #36807
Conversation
Contributes to #35750 Related: dotnet/installer#17760
It looks like tests are failing because the portable RuntimeIdentifier graph can't be found. Probably the code that creates stage 2 needs to be updated to include that file. |
Any idea how to do that? The portable and non portable RID graphs are directly flowing from runtime -> installer and bundled into the SDK there. |
@dsplaisted can you please help with this change? I'm currently quite busy with the VMR work and I think we should finish this work before .NET 9 Preview 1. |
sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.CrossTargeting.targets Line 119 in f2aca45
these two needed? |
Those properties in the sdk are needed, yes. |
Hi, apparently this change broke this doc page by accident? As the |
Thanks, we need to fix the doc page. |
Submitted dotnet/docs#41729 |
In reaction to dotnet/sdk#36807
Contributes to #35750
Related: dotnet/installer#17760
That deleted build task got moved into runtime: https://github.com/dotnet/runtime/blob/faf65649cc5948884e40825889016808b5e36629/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj#L52-L60
cc @tmds