[release/7.0.1xx] Create workloads enumerator lazily in dotnet-new hos #30773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
changed the title
YuliiaKovalova
added
Servicing-consider
Servicing-approved
and removed
Servicing-consider
labels
JanKrivanek
approved these changes
Mar 8, 2023
JanKrivanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--interactive flag isn't passed correctly when specified
Solution
Lazy loading of IWorkloadsRepositoryEnumerator helped to prevent the racing conditions and call TemplatePackageCoordinator.InitializeNuGetCredentialService with relevant -interactive value.
It was agreed to port #28677 in release/7.0.1xx, the stable fix was added in the main #30806
Checks:
[n/a] Added unit tests
[n/a] Added #nullable enable to all the modified files ?