Rename SdkSupportedTargetPlatform, add SupportedTargetPlatform

[sfoslund]

Fixes #12706

cc @terrajobst

[terrajobst]

We should name the group SupportedPlatform but other than that, it looks good.

[terrajobst]

I've talked @pranavkm, he'll make sure the Blazor SDK will do this in their .props file:

<ItemGroup>
    <SupportedPlatform Remove="@(SupportedPlatform)" />
    <SupportedPlatform Include="browser" />
</ItemGroup>

For more details, see the spec.

[terrajobst]

@sfoslund @dsplaisted will this be merged before 3?

[terrajobst]

@sfoslund @dsplaisted will this be merged before 3?

Let's not do a fire drill this week. But we should get it in soon-ish.

[pranavkm]

@dsplaisted would you mind reviewing this?

[wli3]

Need to adjust against #12775

[dsplaisted]

LGTM, but I'm not sure what @wli3 means by this:

Need to adjust against #12775

So I'd make sure to clarify that first

[sfoslund]

will this be merged before 3?

@terrajobst sorry, I was OOF at the beginning of this week. I'll update based on feedback now and get this in this week.

[jeffhandley]

I think @pranavkm mentioned he was going to take a look at this too--but I'm not sure if he took any actions on it yet.

[pranavkm]

I edited some of these files, but looks like @sfoslund's got a handle on this 👍

[sfoslund]

@dsplaisted @terrajobst does this look okay to you?

[dsplaisted]

@dsplaisted @terrajobst does this look okay to you?

Yes, but I'd like clarification from @wli3 on what he meant in this comment

[wli3]

Now I look it in detail. This change has nothing to do with the attribute "SupportedOSPlatformAttribute" in #12775 right? And this rename is to avoid that name conflict. If so, this is good.

[terrajobst]

Now I look it in detail. This change has nothing to do with the attribute "SupportedOSPlatformAttribute" in #12775 right? And this rename is to avoid that name conflict. If so, this is good

Logically related, but independent. This item group is only used by our analyzer.

@mavasani what is required to pass this down? Do we need to register the item group somewhere? Or did you do that already?

[mavasani]

I presume you mean: dotnet/roslyn-analyzers#3950 (comment)?

[sfoslund]

@mavasani things are good on your side for this to go in then?

[mavasani]

@mavasani things are good on your side for this to go in then?

I am not sure I understand the changes in this PR, but updating the analyzers to understand any name chosen here would be a trivial change, so in that sense this PR does not break or hinder the analyzers in anyway.

[sfoslund]

Great, sounds like this is good to go in then. I'll merge it today unless there are any objections.