Include diagnostic level metadata on ResolvedPackageReference #12069
Conversation
This information is needed by the Project System to correctly indicate when a package in the tree has an associated warning or error state.
|
The consumption of this data is in dotnet/project-system#6288. |
src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageDependencies.cs
Outdated
Show resolved
Hide resolved
drewnoakes
force-pushed
the
include-library-diagnostic-level
branch
from
ff326ab to
6f5f5c1
Compare
| @@ -119,6 +119,8 @@ public string ProjectLanguage | |||
| /// </summary> | |||
| public bool EmitLegacyAssetsFileItems { get; set; } = false; | |||
|
|
|||
| public string TargetFrameworkMoniker { get; set; } | |||
There was a problem hiding this comment.
only Diagnostic is relevant to TargetFrameworkMoniker? Should "PackageDependencies" be different when TargetFrameworkMoniker is different? (Although "Diagnostic" is the only thing TargetFrameworkMoniker applied to.)
There was a problem hiding this comment.
If so, maybe we should call it something like DiagnosticTargetFrameworkMoniker
There was a problem hiding this comment.
The input items have already filtered by TargetFrameworkMoniker in ResolvePackageDependencies. I like keeping this property name the same as the MSBuild property that it comes from. The fact that it's currently only used for diagnostics is kind of an implementation detail.
|
The CI looks stuck. You can |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributes to dotnet/project-system#6275.
This information is needed by the Project System to correctly indicate when a package in the tree has an associated warning or error state.