Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom compilers to inject dependencies #4640

Closed
muratg opened this issue Dec 18, 2015 · 1 comment
Closed

Allow custom compilers to inject dependencies #4640

muratg opened this issue Dec 18, 2015 · 1 comment
Labels
needs design
Milestone
Backlog

Comments

@muratg
Copy link

muratg commented Dec 18, 2015

From @Alxandr on May 30, 2015 17:56

Any project that is build in F# will as a general rule depend on FSharp.Core. YoloDev.Dnx.FSharp itself also depends on FSharp.Core, but since it's normally added as a build time only dependency, it's dependency on FSharp.Core doesn't get transferred to the project produced by it. I think there should either be an API that allows me to inject dependencies into the project being built by the custom compiler, or at least some way to note that FSharp.Core should be transfered as a dependency to peer projects even if YoloDev.Dnx.FSharp is listed as built-time only.

The problem is that as it stands now, if people forget to add the dependency on FSharp.Core, everything will build just fine, but will break at runtime, which is a really bad situation.

Copied from original issue: aspnet/dnx#1994
@TheRealPiotrP
Copy link
Contributor

This is already fixed in dotnet-compile-fsc.

wli3 referenced this issue in wli3/cli Jul 14, 2017
@eerhardt
Merge pull request #581 from eerhardt/FixNETCoreApp11
8d7a8dd 
Fix Publish failing when an app targets netcoreapp1.1 and a P2P to a project that targets netcoreapp1.1
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/microsoft/msbuild build 2…
f5cf646 
…0200624.3 (#4640)

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.7.0-preview-20324-02 -> To Version 16.7.0-preview-20324-03

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs design
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@muratg @TheRealPiotrP @msftgits