Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom compilers to inject sources into symbol packages #4639

Closed
muratg opened this issue Dec 18, 2015 · 6 comments
Closed

Allow custom compilers to inject sources into symbol packages #4639

muratg opened this issue Dec 18, 2015 · 6 comments
Milestone

Comments

@muratg
Copy link

muratg commented Dec 18, 2015

From @Alxandr on May 30, 2015 17:58

With how my new F# compiler for DNX work, I end up with empty symbol packages. Now, symbolsource doesn't support DNX targets yet so it's not that much of a problem ^^, but I would still like for a way for my compiler to DNU what sources/additional sources to include in the symbols package.

Copied from original issue: aspnet/dnx#1995

@TheRealPiotrP
Copy link
Contributor

@enricosada is this still an issue?

@enricosada
Copy link
Contributor

no @piotrpMSFT this issue can be closed, portablepdb or pdb on windows are supported.
these need to be configured in project.json (like c#)

@Alxandr
Copy link

Alxandr commented May 25, 2016

I'm not saying this isn't resolved, but @enricosada when I mad this issue, it had nothing to do with portable PDBs.

@enricosada
Copy link
Contributor

sry @Alxandr i confused empty symbol package with empty debug symbols assembly (thinking about the empty pdb generated atm by dotnet build with f#)

so about symbol package:

using netcore sdk preview1:

dotnet new --lang f#
dotnet restore
dotnet pack

output of dotnet pack:

Producing nuget package "testsy.1.0.0" for testsy
testsy -> E:\temp\testsy\bin\Debug\testsy.1.0.0.nupkg
Producing nuget package "testsy.1.0.0.symbols" for testsy
testsy -> E:\temp\testsy\bin\Debug\testsy.1.0.0.symbols.nupkg

and testsy.1.0.0.symbols.nupkg contains Program.fs (the source file).

|   testsy.nuspec
|   [Content_Types].xml
|
+---lib
|   \---netstandard1.5
|           testsy.dll
|           testsy.pdb
|           testsy.runtimeconfig.json
|
+---src
|       Program.fs
|
\---_rels
        .rels

That was the issue before @Alxandr ?

@Alxandr
Copy link

Alxandr commented May 26, 2016

Yes. I believe this was fixed by convention when the F# compiler started using the same fields for what files to compile as the C# compiler did. Still think it should be allowed for the compiler to inject into what goes into the symbols package, but yeah, this works.

@TheRealPiotrP
Copy link
Contributor

The team is actively working on enabling MSBuild and the component affected will be superseded by the new project system, so I am closing this issue.

wli3 referenced this issue in wli3/cli Jul 14, 2017
Produce Only Preprocessor Files in ProduceContentAssets
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
…0200624.2 (#4639)

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.7.0-preview-20323-01 -> To Version 16.7.0-preview-20324-02

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants