Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime returns incorrect framework short name when netcore451 is specified in project.json #4636

Closed
muratg opened this issue Dec 18, 2015 · 7 comments
Closed

runtime returns incorrect framework short name when netcore451 is specified in project.json #4636

muratg opened this issue Dec 18, 2015 · 7 comments
Labels
Bug
Milestone
Backlog

Comments

@muratg
Copy link

muratg commented Dec 18, 2015

From @abpiskunov on June 8, 2015 17:28

See this issue for full details and repro: https://github.com/aspnet/Tooling-Internal/issues/344

Copied from original issue: aspnet/dnx#2032
@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @davidfowl on September 20, 2015 1:1

/cc @anurse

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @anurse on September 21, 2015 2:40

win81 is the correct normalized short-form name for .NETCore, Version=v4.5.1... The tooling should be using long-form names everywhere since they are unambiguous.

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @abpiskunov on September 21, 2015 14:36

How do we get this correct-long-form name for each framework moniker ? We take monikers that runtime sends us and don't have our own name resolution logic.

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @abpiskunov on September 21, 2015 14:37

In any case , runtime should be consistent with the info it sends us.

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @davidfowl on September 21, 2015 15:21

We should fix this

@TheRealPiotrP
Copy link
Contributor

@abpiskunov do you still see this issue in ProjectModelServer?

@abpiskunov
Copy link
Contributor

no, it does not repro in dotnet cli

@muratg muratg closed this as completed May 26, 2016
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/microsoft/msbuild build 2…
8907e4e 
…0200623.1 (#4636)

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.7.0-preview-20310-07 -> To Version 16.7.0-preview-20323-01

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@abpiskunov @muratg @TheRealPiotrP @msftgits