Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'dnu wrap' does not add the framework assemblies list to the generated project.json files #4634

Closed
muratg opened this issue Dec 18, 2015 · 1 comment
Milestone

Comments

@muratg
Copy link

muratg commented Dec 18, 2015

From @kichalla on June 19, 2015 16:33

The title of this issue is just my assumption of probably how it should have been. More details below:

I have a regular .Net class library whose references are like below:
Here all references except Newtonsoft.Json and LibraryA are from the GAC
image

I wrap the following command to wrap this project:
dnu wrap .\LibraryB\LibraryB.csproj --configuration Release -f dnx451 -i

Now since my regular .Net project can be used for vNext, I did a dnu pack --out c:\beta5signoff\dnuwrappackages
But when I look at the references of the generated .nupkg in package explorer, I see the following:
image

Note that it does not have System.Runtime.Serialzation in the 'framework assembly references` section.

I think the problem could be with how the wrapping is generating the project.json content. For example, following was the content of project.json:

{
  "version": "1.0.0-*",
  "frameworks": {
    "net451": {
      "wrappedProject": "LibraryB.csproj",
      "bin": {
        "assembly": "obj/{configuration}/LibraryB.dll",
        "pdb": "obj/{configuration}/LibraryB.pdb"
      },
      "dependencies": {
        "Newtonsoft.Json": "6.0.8",
        "LibraryA": "1.0.0-*"
      }
    }
  }
}

Notice that this does not have the "frameworkAssemblies" section. Should we actually have it?

/cc: @ChengTian

Copied from original issue: aspnet/dnx#2099

@blackdwarf
Copy link

DNU wrap is not a CLI construct anymore so I'm closing this.

wli3 referenced this issue in wli3/cli Jul 14, 2017
Include the new Vsixes in the signing template
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
…5.7.0.6668 (#4634)

NuGet.Build.Tasks
 From Version 5.7.0-rtm.6665 -> To Version 5.7.0-rtm.6668

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants