Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per framework file exclude #4613

Closed
muratg opened this issue Dec 18, 2015 · 5 comments
Closed

Per framework file exclude #4613

muratg opened this issue Dec 18, 2015 · 5 comments
Milestone
Backlog

Comments

@muratg
Copy link

muratg commented Dec 18, 2015

From @JamesNK on August 22, 2015 1:45

Right now exclude is for all frameworks. It would be useful to be able to exclude files for certain frameworks on build.

Copied from original issue: aspnet/dnx#2540
@muratg muratg self-assigned this Dec 18, 2015
@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @glennc on August 24, 2015 18:3

I like the idea, but don't think it fits into any of the milestones we have at the moment. So backlog for now.

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @anurse on August 24, 2015 20:45

As a workaround, and yes I know it's kinda gross, you can wrap the whole file in #if

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @JamesNK on August 24, 2015 21:33

That's what I did. It was just a pain in the butt getting all files working with all frameworks: JamesNK/Newtonsoft.Json@a9ea63d

Anyway, not blocking.

@muratg
Copy link
Author

muratg commented Dec 18, 2015

From @Mpdreamz on September 14, 2015 12:49

Huge +1 to this, would reduce the number of needed ifdefs.

@muratg muratg removed their assignment Dec 18, 2015
@TheRealPiotrP
Copy link
Contributor

This will be addressed in the new project system.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20200…
09cb09c 
…611.5 (#4613)

Microsoft.Net.Compilers.Toolset
 From Version 3.7.0-3.20310.5 -> To Version 3.7.0-3.20311.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
@JanKrivanek
Honor explicitly requested package identifier during uninstall (dotne…
5279c06 
…t#4613)

* dotnet#4156 Honor explicitly requested package identifier during uninstall

* dotnet#4613 Improve logic (path expansion only for local packages), add unit test
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 21, 2022
@JanKrivanek
Honor explicitly requested package identifier during uninstall (dotne…
f4db969 
…t#4613)

* dotnet#4156 Honor explicitly requested package identifier during uninstall

* dotnet#4613 Improve logic (path expansion only for local packages), add unit test
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
@JanKrivanek
Honor explicitly requested package identifier during uninstall (dotne…
9798369 
…t#4613)

* dotnet#4156 Honor explicitly requested package identifier during uninstall

* dotnet#4613 Improve logic (path expansion only for local packages), add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@muratg @TheRealPiotrP @msftgits