-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Build verb from Compile #4599
Comments
@cdmihai we still need to define what this command does all-up. Can you add also a Readme.md that is tailored as with the rest of the commands in the repo that outlines this? |
Sure. I'll edit the readme and update the PR. In short, given a root project, Build expands it into a graph of projects (root project + dependencies) and then compiles that graph either incrementally or non incrementally. For each node in the graph, Build invokes Compile to compile that node. Compile is then responsible for knowing how to setup and call the compiler. For users, the difference mainly lies in calling build instead of compile. |
Agreed we should have. I'm okay if that happens succinctly on a future pull request. Since lots of folks are blocked on this I wouldn't hold off the PR |
For sure, no need to block the pr on this. Just for tracking. |
I created a readme for Build: https://github.com/cdmihai/cli/wiki/Build-readme I'll include them in my current PR once I'm done resolving conflicts :) |
Thanks, will take a look at the PR. Thanks, Sent from my tricorder On Fri, Dec 18, 2015 at 4:55 PM -0800, "Mihai Codoban" <[email protected]mailto:[email protected]> wrote: I created a readme for Build: https://github.com/cdmihai/cli/wiki/Build-readme I'll include them in my current PR once I'm done resolving conflicts :) Reply to this email directly or view it on GitHubhttps://github.com/dotnet/cli/issues/532#issuecomment-165929075. |
Done in dotnet/cli#663 |
…0200605.5 (#4599) Microsoft.Build.Localization , Microsoft.Build From Version 16.7.0-preview-20305-04 -> To Version 16.7.0-preview-20305-05 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Compile is having two main responsibilities (happy paths):
In preparing for incremental compilation we need to separate responsibility 1. into a new verb,
Build
.Eventually, Build needs to also:
I'll start with two PRs:
Here is the updated user experience from issue #4403
The text was updated successfully, but these errors were encountered: