Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu/Mac build breaks with spaces in the path #4597

Closed
brthor opened this issue Dec 16, 2015 · 7 comments
Closed

Ubuntu/Mac build breaks with spaces in the path #4597

brthor opened this issue Dec 16, 2015 · 7 comments
Assignees
@brthor
Labels
Bug
Milestone
Backlog

Comments

@brthor
Copy link
Contributor

brthor commented Dec 16, 2015

Easy to Repro:

git clone https://github.com/dotnet/cli "cli space test"
cd "cli space test"
./build.sh

Output on Ubuntu 14.04:

azureuser@work:~/cli space test$ ./build.sh
./build.sh: line 38: [: too many arguments
*** Building dotnet tools version 1.0.0.1450301551 - Debug ***
./build.sh: line 57: /home/azureuser/cli: Is a directory
@brthor brthor self-assigned this Dec 16, 2015
@brthor
Copy link
Contributor Author

brthor commented Dec 16, 2015

This is causing some CI instability in mac builds. So scheduling for Jan

@Sridhar-MS

@brthor
Copy link
Contributor Author

brthor commented Dec 18, 2015

Plumbed through this today. Basically needed quotes everywhere.

The solution is blocked on #4593

@Sridhar-MS
Copy link
Contributor

Is it possible to submit a partial PR for the build scripts alone? We can fix #4593 independently.

@brthor
Copy link
Contributor Author

brthor commented Dec 18, 2015

Yes, will do. It's hard to verify if there are further issues past where #4593 is breaking though. So I would leave this issue open until #4593 is closed.

@brthor
Copy link
Contributor Author

brthor commented Dec 18, 2015

@Sridhar-MS see dotnet/cli#545

@blackdwarf
Copy link

I'm pretty sure this works now, so closing. If it still a problem, reopen.

@brthor
Copy link
Contributor Author

brthor commented Jul 22, 2016 •
edited
Loading

This is most likely not fixed, will confirm later

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/microsoft/msbuild build 2…
8905b67 
…0200605.3 (#4597)

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.7.0-preview-20304-07 -> To Version 16.7.0-preview-20305-03

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brthor brthor

Labels
Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@blackdwarf @msftgits @Sridhar-MS @brthor