Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage1 publishing copies binaries over to Stage2 #4564

Closed
Sridhar-MS opened this issue Dec 11, 2015 · 4 comments
Closed

Stage1 publishing copies binaries over to Stage2 #4564

Sridhar-MS opened this issue Dec 11, 2015 · 4 comments
Assignees
Milestone

Comments

@Sridhar-MS
Copy link
Contributor

*** Building stage1 dotnet using downloaded stage0 ... ***
15:56:44 Publishing �[33mdotnet�[39m for �[33mDNXCore,Version=v5.0�[39m/�[33mubuntu.14.04-x64�[39m
15:56:46 Compiling �[33mMicrosoft.DotNet.ProjectModel�[39m for �[33mDNXCore,Version=v5.0�[39m
15:56:48 Copy From: /mnt/j/workspace/dotnet_cli/debug_ubuntu/artifacts/ubuntu.14.04-x64/stage1/bin/Microsoft.DotNet.ProjectModel.dll
15:56:48 To: /mnt/j/workspace/dotnet_cli/debug_ubuntu/artifacts/ubuntu.14.04-x64/stage2/bin/
15:56:48 Copy From: /mnt/j/workspace/dotnet_cli/debug_ubuntu/artifacts/ubuntu.14.04-x64/stage1/bin/Microsoft.DotNet.ProjectModel.pdb
15:56:48 To: /mnt/j/workspace/dotnet_cli/debug_ubuntu/artifacts/ubuntu.14.04-x64/stage2/bin/

Probably related to #4539.

@TheRealPiotrP
Copy link
Contributor

@cdmihai is this something you want to pick up while you're thinking about eliminating post-compile scripts?

@cdmihai
Copy link
Contributor

cdmihai commented Dec 30, 2015

Yes, we were actually studying this exact behaviour yesterday when we were looking into taking them out.

We found out that the place-binary script always copies to stage2, indifferent of what you compile So compilation of stage 1 copies output to stage 2. Compilation of stage2 copies output over itself. This got us a bit puzzled about the meaning of the script so we removed it entirely and CLI still builds itself, with everything passing. :)

I'll put out a PR out next week (removing the scripts turns on incremental compilation and I still want to make sure that one works reasonably well ...)

@cdmihai cdmihai assigned cdmihai and unassigned Sridhar-MS Dec 30, 2015
@TheRealPiotrP
Copy link
Contributor

Goal of the script is to enable dev cycle. I update dotnet-foo, I compile dotnet-foo [which replaces in stage2], I run dotnet-foo and my new bits are in place...

@cdmihai
Copy link
Contributor

cdmihai commented Feb 2, 2016

Solved by removing the place-binary script and enabling incremental build in the dev cycle. Developers should call build and set it to output in stage2.

Issue dotnet/cli#790 discusses more advanced mechanism to make the above easier.

@cdmihai cdmihai closed this as completed Feb 2, 2016
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
…5.7.0.6618 (#4564)

NuGet.Build.Tasks
 From Version 5.7.0-preview.1.6609 -> To Version 5.7.0-preview.2.6618

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants