Update the sample to target net5 #4096
Conversation
It generates warnings because it targets out-of-support 3.0
The CI seems to only support .NET 5 and it doesn't really matter for the sample if it's 3.1 or 5.
vitek-karas
changed the title
There was a problem hiding this comment.
We should probably update the prerequisites for the tutorial that uses this too (maybe with a note that the sample uses 5.0, but support was added in 3.0) - https://github.com/dotnet/docs/blob/master/docs/core/tutorials/creating-app-with-plugin-support.md
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp3.0</TargetFramework> | |||
| <TargetFramework>net5</TargetFramework> | |||
There was a problem hiding this comment.
The version is called out in the readme too.
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp2.1</TargetFramework> | |||
| <TargetFramework>net5</TargetFramework> | |||
There was a problem hiding this comment.
Would it make sense to add a Directory.Build.props to set TargetFramework for all these projects?
There was a problem hiding this comment.
@elinor-fung That's an interesting idea. We're looking at how to update all the samples on the release cadence. See dotnet/docs#22271. Can you add thoughts on how to make that easier on that issue?
|
@elinor-fung thanks for pointing out the docs update: dotnet/docs#22297 |
It generates warnings because it targets out-of-support 3.0