Add information about state machine MoveNext methods #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
added
the
area-NativeAOT-coreclr
|
Decided to also push out the commit that adds demangling. Not sure if I'll be able to do the deluxe version that actually shows these as locals since the C++ EE might not be involved after all. Still checking. The current experience is:
|
|
The debug information for the state machine closure itself is left intact:
|
jkotas
reviewed
Feb 23, 2021
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/UserDefinedTypeDescriptor.cs
Show resolved
Hide resolved
This exposes the debug records necessary to identify state machine MoveNext methods. Only implementing this for the portable PDB reader. It didn't look straightforward to do for unmanaged PDBs but those are Windows only anyway.
Produces human-readable debug information for the 'this' parameter of state machines. This unmangles and hides fields as necessary to produce better debug information for the state machine. We create a new type to describe the 'this' parameter instead of using the debug information of the state machine itself.
MichalStrehovsky
force-pushed
the
stateMachine
branch
from
481542a to
a40e438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the debug records necessary to identify state machine MoveNext methods. Only implementing this for the portable PDB reader. It didn't look straightforward to do for unmanaged PDBs but those are Windows only anyway.