Merge from dotnet/runtime #374

jkotas · 2020-11-21T03:34:06Z

No description provided.

…pp build time when relinking the wasm runtime. (#44715) * Add the emscripten version to the wasm runtime pack and check it at app build time when relinking the wasm runtime. * Update src/mono/wasm/Makefile Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]>

… (#35042) * Handle unicode and e-notation differences between S.T.J and J.N tests Fixes #32350 * Remove TODO * Bumping CI * Bump CI * Handle relaxed escaping and precision properly * Move else if * Move else if back * Remove relaxedEscaping param and skip whitespace * Apply Jozkee final touches * Add missing period Co-authored-by: David Cantu <[email protected]>

- Avoid StringBuilder marshaling - Let CreateProcess{WithLogonW} determine the current working directory - Avoid creating SafeHandles for GetCurrentProcess() - Avoid forcing ProcessStartInfo.ArgumentList into existence just to check if it contains anything - Prefer using ProcessStartInfo.Arguments in Start(string, IEnumerable<string>) if there's only one string in the enumerable - Use ValueStringBuilder instead of StringBuilder to build up arguments, so as to use stack space / pooled char[]s and avoid actually needing to produce strings. - Avoid unnecessary SafeHandle for PROCESS_INFORMATION.hThread

When Regex.Replace doesn't actually need to replace anything, we're inadvertently not returning a previously rented ArrayPool array to the pool. On repeated use, that drains the pool of the desired size, such that every attempt ends up allocating a new array, even if there are no replacements to be made. The fix is to lazily rent from the pool. This not only fixes the problem, but helps perf further by not taking the rental cost unless we actually need an array to store a replacement segment.

* Fix non-thread-safe EntityTagHeaderValue.Any It was being published before fully populated. * Address PR feedback * Update EntityTagHeaderValue.cs

* Fix building host lineup packages. Signed-off-by: Jeremy Koritzinsky <[email protected]> * Update src/installer/pkg/projects/host-packages.proj Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Viktor Hofer <[email protected]>

…s. (#44819) Co-authored-by: vargaz <[email protected]>

Changing the JIT-EE GUID invalidates previous SuperPMI collections, necessitating a re-collection. As a proxy for determining whether the JIT-EE GUID has changed, just trigger anytime the corinfo.h file changes.

- MethodCallExpression can take nullable instance when static method - LambdaExpression.Update does not return null in any case Resolves #44821 Resolves #44822

* Make $(TargetOS) lowercase windows in eng/coredistools.target * Make $(TargetOS) lowercase windows in src/tests/Common/Directory.Build.targets

…#44675) * Fix NRE when default value is null and ServiceCallSite is not found

* Enable nullable annotations for M.E.L.Abstractions * Corrections from review * LoggerExtensions.cs: params object?[] -> params object?[] * using Nullable Annotations, to allow annotations on relevant projects, not yet enabled * formatter not null

* Update dependencies from https://github.com/dotnet/arcade build 20201113.2 Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20563.2 * Update global.json Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Juan Hoyos <[email protected]>

* make ValidateCacheKey and CheckDisposed inlinable by moving throws to separate methods * ensure that the check for expiration does not require a method call for the most common case * update the last expiration scan when the Scan Task starts actual work * Apply suggestions from code review Co-authored-by: Stephen Toub <[email protected]>

* Use read-only auto-implemented property in src\libraries\Common Use read-only auto-implemented property (RCS1170) https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1170.md * Revert changes except to ComEventsMethod

Resulting in several hundred Func, IEnumerable, set, and string allocations at startup.

* Improve unit test coverage for GetUninitializedObject * Normalize most checks between coreclr and mono

…DefaultLogMessage (#44765) It's resulting in a string[] allocation and a string allocation, when we can instead just make a few more individual calls to Write and stackalloc the integer.

…nsitively uses it through the Microsoft.NETCore.DotNetHostResolver package. (#44883)

… (#44696)

jkotas · 2020-11-21T08:30:04Z

@sandreenko Many tests are failing in this integration with:

/Users/runner/work/1/s/src/coreclr/src/jit/assertionprop.cpp:1628
2020-11-21T08:09:55.0171590Z           Assertion failed '(lvaTable[assertion->op1.lcl.lclNum].lvType != TYP_REF) || (assertion->op2.u1.iconVal == 0)' in

I suspect that it is caused by dotnet/runtime#44398. Could you please take a look?

sandreenko · 2020-11-21T08:42:26Z

Sure, could I just follow what CI is doing for a repro or is there a faster way to debug this repo?

jkotas · 2020-11-21T17:41:45Z

I have extracted a simple repro at:

xcopy /s \\jkotas9\drops\runtimelab-374 .
runme.bat

Note that the JIT .dll is renamed to clrjitilc.dll, so if you build a private you need to replace the clrjitilc.dll with it.

jkotas · 2020-11-21T17:45:07Z

If you would prefer to just build locally, here is the workflow that I use (based on https://github.com/dotnet/runtimelab/blob/feature/NativeAOT/docs/workflow/building/coreclr/nativeaot.md):

build nativeaot+libs -lc release -rc checked
open src\coreclr\src\tools\aot\ilc.sln in VS
set configuration to checked x64
in the project debug tab, set Application Arguments to @C:\runtimelab\artifacts\bin\repro\x64\Checked\compile-with-Release-libs.rsp (or wherever the project is on your machine) and also check "Enable native debugging"
Append -O to C:\runtimelab\artifacts\bin\repro\x64\Checked\compile-with-Release-libs.rsp
Change Program.cs in repro project to:

using System;
using System.Threading;

new ThreadLocal<int>().ToString();

F5

You should see the assert

R2R testing was failing by hitting an assert about unimplemented getMethodModule, called as part of R2R-only devirtualization handling in the JIT. I didn't determine why this regressed now. Fixes #45016

… (#44688) * Fix GetNonRandomizedHashCodeOrdinalIgnoreCase * Add a test Co-authored-by: Levi Broderick <[email protected]>

…alue (#44945) instead of hopping over layers of ToString indirections which end up calling HexConvertor anyway.

* Drop Convert static constructor dependency from RuntimeTypeto make it trimmable Co-authored-by: Jan Kotas <[email protected]>

Fix a few typos

Use IndexOf to search for positions rather than open-coded loops, taking advantage of vectorization to improve throughput.

…(#45075) Co-authored-by: Stephen Toub <[email protected]>

…s too long to run (#45081) Co-authored-by: Geoffrey Kizer <[email protected]>

* Skip Invariant initalization test for CultureData.Invariant * Feedback

…need them. (#45076) Fixes dotnet/runtime#44269.

… observations. (#44790) * Use `argIsInvariant` instead of `argNode->OperIsConst()`. * add a small repro test for the current issue.

We currently have several hundred uses of `Array.Empty<Type>()` and several hundred uses of `Type.EmptyTypes`. This just changes the repo to use the latter consistently.

ILVerify is published on nuget now. It is not required to use the nightly feed anymore.

- Refactoring paves way for related work in dotnet/runtime#32520 - Fixes some possible GC holes in the reflection stack

* Fix native build on arm and arm64. * Fix a typo.

* Fix CoreRT frozen strings handling. * Review response. * Delete noway_assert. * Additional checks. * Fix failures.

vargaz and others added 30 commits November 17, 2020 16:53

[Android] Add ability to set env vars via command line (#44644)

909f092

Remove HashProviderDispenser.Android.cs (#44814)

573f998

Update archives package to fix zip/tar naming. (#44827)

38743da

Fix non-thread-safe EntityTagHeaderValue.Any (#44802)

1a6d27d

* Fix non-thread-safe EntityTagHeaderValue.Any It was being published before fully populated. * Address PR feedback * Update EntityTagHeaderValue.cs

Restore Snapcraft files. (#44812)

eefecfc

[wasm] Use the functions in emscripten/stack.h to compute stack bound…

6f29f0b

…s. (#44819) Co-authored-by: vargaz <[email protected]>

Trigger SuperPMI collection pipeline if JIT-EE GUID changes (#44846)

181d646

Changing the JIT-EE GUID invalidates previous SuperPMI collections, necessitating a re-collection. As a proxy for determining whether the JIT-EE GUID has changed, just trigger anytime the corinfo.h file changes.

Update nullability on some LINQ expression methods (#44844)

7d7ef2c

- MethodCallExpression can take nullable instance when static method - LambdaExpression.Update does not return null in any case Resolves #44821 Resolves #44822

Make $(TargetOS) lowercase windows in eng/coredistools.target (#44845)

08ee531

* Make $(TargetOS) lowercase windows in eng/coredistools.target * Make $(TargetOS) lowercase windows in src/tests/Common/Directory.Build.targets

Fix NRE when default value is null and ServiceCallSite is not found (…

0d122b1

…#44675) * Fix NRE when default value is null and ServiceCallSite is not found

Fix decoding GC information in R2RDump (#44682)

88ecbab

Integrate misc fixes from dotnet/runtimelab:NativeAOT (#44851)

1e8adf2

Remove unnecessary suppression (#44811)

6cb16e1

[browser][wasm] Cleanup debug statement (#44870)

9765835

Fix a comment in the bundle marker (#44874)

35e535e

Remove most LINQ usage from Microsoft.Extensions.Configuration (#44825)

57c14a2

Resulting in several hundred Func, IEnumerable, set, and string allocations at startup.

GetUninitializedObject fixes & improved tests (#44843)

2d80101

* Improve unit test coverage for GetUninitializedObject * Normalize most checks between coreclr and mono

Avoid string.Concat(params string[]) in SimpleConsoleFormatter.Create…

38259c8

…DefaultLogMessage (#44765) It's resulting in a string[] allocation and a string allocation, when we can instead just make a few more individual calls to Write and stackalloc the integer.

Restore the Microsoft.NETCore.DotNetAppHost package since the SDK tra…

eeba597

…nsitively uses it through the Microsoft.NETCore.DotNetHostResolver package. (#44883)

Remove closure allocations from ServiceCollectionDescriptorExtensions…

7426c10

… (#44696)

Avoid string.Split in LoggerRuleSelector.IsBetter (#44753)

4204aa9

Fix nullability

5de9ee2

jkotas force-pushed the merge-master branch from 8afaa9d to 5de9ee2 Compare November 21, 2020 07:48

BruceForstall and others added 7 commits November 21, 2020 10:46

Implement getMethodModule (#45046)

8a3dc16

R2R testing was failing by hitting an assert about unimplemented getMethodModule, called as part of R2R-only devirtualization handling in the JIT. I didn't determine why this regressed now. Fixes #45016

Handle non-ASCII strings in GetNonRandomizedHashCodeOrdinalIgnoreCase…

eb5df0d

… (#44688) * Fix GetNonRandomizedHashCodeOrdinalIgnoreCase * Add a test Co-authored-by: Levi Broderick <[email protected]>

Use HexConverter directly when producing hex representation of enum v…

c4c3981

…alue (#44945) instead of hopping over layers of ToString indirections which end up calling HexConvertor anyway.

Drop Convert static constructor dependency from RuntimeType (#45054)

bb492cb

* Drop Convert static constructor dependency from RuntimeTypeto make it trimmable Co-authored-by: Jan Kotas <[email protected]>

Fix Typos (#45024)

f67389f

Delete unused WinRT related strings (#45067)

12ae956

Fix a few typos

Improve throughput of Environment.GetEnvironmentVariables() (#45057)

bf302de

Use IndexOf to search for positions rather than open-coded loops, taking advantage of vectorization to improve throughput.

sandreenko mentioned this pull request Nov 23, 2020

Fix CoreRT frozen strings handling. dotnet/runtime#45095

Merged

marek-safar and others added 13 commits November 23, 2020 13:58

Create cancellation token registration wrapper only when it's needed …

7218577

…(#45075) Co-authored-by: Stephen Toub <[email protected]>

disable ReadWrite_Success_Large test for CryptoStream because it take…

e8c4f22

…s too long to run (#45081) Co-authored-by: Geoffrey Kizer <[email protected]>

Skip Invariant initialization test for CultureData.Invariant (#45064)

8861c41

* Skip Invariant initalization test for CultureData.Invariant * Feedback

[Android] Introduce AndroidApkFileReplacerTask task (#44993)

65d42f0

Add support for stack walks on wasm for the reflection methods which …

e274015

…need them. (#45076) Fixes dotnet/runtime#44269.

Use argIsInvariant instead of argNode->OperIsConst() for inlining…

78adc93

… observations. (#44790) * Use `argIsInvariant` instead of `argNode->OperIsConst()`. * add a small repro test for the current issue.

Use Type.EmptyTypes consistently (#45112)

e2099f6

We currently have several hundred uses of `Array.Empty<Type>()` and several hundred uses of `Type.EmptyTypes`. This just changes the repo to use the latter consistently.

Update ILVerify readme (#45123)

202f6e1

ILVerify is published on nuget now. It is not required to use the nightly feed anymore.

Remove most uses of RuntimeTypeHandle.Allocate (#45085)

3f89665

- Refactoring paves way for related work in dotnet/runtime#32520 - Fixes some possible GC holes in the reflection stack

Fix native build on arm and arm64. (#45131)

89383aa

* Fix native build on arm and arm64. * Fix a typo.

Fix CoreRT frozen strings handling. (#45095)

1fa2054

* Fix CoreRT frozen strings handling. * Review response. * Delete noway_assert. * Additional checks. * Fix failures.

Merge remote-tracking branch 'upstream/runtime-master' into merge-master

dfa1945

Fix cgroups

de84734

jkotas force-pushed the merge-master branch from d72f212 to de84734 Compare November 24, 2020 09:34

jkotas merged commit 7faa1f0 into dotnet:feature/NativeAOT Nov 24, 2020

jkotas deleted the merge-master branch November 24, 2020 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge from dotnet/runtime #374

Merge from dotnet/runtime #374

jkotas commented Nov 21, 2020

jkotas commented Nov 21, 2020

sandreenko commented Nov 21, 2020

jkotas commented Nov 21, 2020

jkotas commented Nov 21, 2020

Merge from dotnet/runtime #374

Merge from dotnet/runtime #374

Conversation

jkotas commented Nov 21, 2020

jkotas commented Nov 21, 2020

sandreenko commented Nov 21, 2020

jkotas commented Nov 21, 2020

jkotas commented Nov 21, 2020