Add analyzer to flag converting from DllImport to GeneratedDllImport #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a coarse check to flag
DllImport
methods where switching toGeneratedDllImport
can be useful. Flags theDllImport
method if it has one of:SetLastError=true
PreserveSig=false
Disabled by default. To enable, add to editorconfig:
dotnet_diagnostic.DLLIMPORTGENANALYZER015.severity = <severity>
Was able to run against a local build of libraries (not just NetCoreApp) on Windows (using https://github.com/elinor-fung/runtime/tree/useDllImportGenerator)
-os Linux
: 1460 warnings-os OSX
: 1210 warningscc @AaronRobinsonMSFT @jkoritzinsky