-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CI/CD pipeline based on the standalone template #308
Set up CI/CD pipeline based on the standalone template #308
Conversation
* Update readme with existing experiments * Add "CreateAnExperiment.md"
* Update README with feature/regexsrm * Update README.md
…ures (dotnet#238) * Add arcade common files * Add standalone library template for experiments that don't need runtime features * Add documentation to README.md * PR Feedback. Co-authored-by: Jan Kotas <[email protected]> * Quick fixups in README.md * PR Feedback * Simplify yml templates Co-authored-by: Jan Kotas <[email protected]>
…ortgenerator-hookup-build
3831f15
to
ea7be41
Compare
ea7be41
to
6696c0f
Compare
I may need some help with getting Linux and Mac onboard. Looks like there's something up with the clang support in DNNE that isn't hooked up quite right, but I might be wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I want to understand ownership here. What files do we own and what files does the engineering team own?
@@ -0,0 +1,16 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who updates this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add an arcade subscription and then it would be auto update.
@jkoritzinsky DNNE assumes that |
@@ -11,6 +11,6 @@ | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need the runtimes section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need the runtimes section to get some bug fixes in the hosting APIs for components. If we didn't need these bug fixes (or if they were in .NET 5), we wouldn't have the section.
I added |
…DllImportGenerator
Signed-off-by: Jeremy Koritzinsky <[email protected]>
6696c0f
to
106540b
Compare
|
…enerator-hookup-build Commit migrated from dotnet/runtimelab@c6ef6e1
This PR merges in the standalone template that @safern designed and adapts it to enable building DllImportGenerator.
Commits after 3e1b2ad have the changes to the template to integrate into our build; all commits before it are from the template.
There are now
build.cmd
andbuild.sh
scripts that are the frontend of the Arcade build in the repo root.The following commands will be useful from the command line:
build.cmd
to build the repobuild.cmd -test
to build the repo and run unit testsbuild.cmd -integrationtest
to build the repo and run integration testsbuild.cmd -test -integrationtest
to build the repo and run all testsYou'll need to run
git clean -xdf
after pulling down a branch with this work since it changes the output directories to live underartifacts
, so some files in the oldobj
directories cause confilcts.Once you've run
build.cmd
from the root of the repo once, you can develop, build, and test the project entirely from within VS or VSCode. The only time you need to run the root build script is when we update the runtime that we run tests on (useful for utilizing runtime bug fixes to improve our tests).I'm going to request that we do not Squash Merge or Rebase Merge this PR. I want to preserve the history of the standalone template (and I don't want git history to show that I own it).